GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add all seven of the javafx modules to JavaBuild.java by vsquared · Pull Request #856 · processing/processing4

Conversation

@vsquared

@vsquared vsquared commented Nov 16, 2024 •
edited by Stefterv
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Please add _all seven of the javafx modules so that we may use JavaFX controls in our apps. Thanks.

Closes processing/processing4-javafx#17
Closes processing/processing4-javafx#15

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hx2A reacted with thumbs up emoji hx2A reacted with heart emoji hx2A reacted with rocket emoji hx2A reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction
  • 👀 1 reaction
@vsquared
Create vsquared-patch-1
1de90d4
Please add _all seven of the javafx modules so that we may use JavaFX controls in our apps. Thanks.
@hx2A

hx2A commented Nov 16, 2024

Copy link
Copy Markdown
Contributor

I'd like to second this. This change would also make it much easier to use JavaFX with py5.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SableRaf
SableRaf requested a review from Stefterv November 16, 2024 23:05
@SableRaf SableRaf changed the title Update JavaBuild.java Add all seven of the javafx modules to JavaBuild.java Nov 16, 2024
@SableRaf

SableRaf commented Nov 16, 2024

Copy link
Copy Markdown
Collaborator

Hi @vsquared and thanks for your suggestion. It looks like the current commit just adds a file to the root of the repository with instructions for modifying JavaBuild.java, instead of directly making the change in the file. Could you update the PR to modify JavaBuild.java directly instead so we can properly review the proposed changes?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsquared

vsquared commented Nov 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

After modifying two different Processing editors with the above change my observation is that adding the seven javafx jar files to the sketch folder is no longer necessary. I have no experience using javafx in IntelliJ or testing on a platform other than macos. My impression is that adding all the jar files to the sketch folder sometimes fails when trying to run javafx code in an editor that has not been modified. I cannot be 100% certain about this and it needs further study. Nevertheless, I don't think the average user wants to go to all the bother to find the seven jar files and copy them to the sketch folder just to run a javafx demo. It would be easier for everyone if a simple one line change was made to the editor. I know this works for macos, but have not tried it on Windows or Linux.
Addendum:
Processing 4.3 failed to run a javafx app with all seven jar files in sketch folder, either lying free or inside a 'code' folder. Another copy of a Processing 4.3 editor modified with the changes above will run the javafx demo without the addition of jar files.
Processing 4.3.1 on macos also failed to run a javafx app with all seven jar files in the sketch folder, both lying free and inside a 'code' folder.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsquared

vsquared commented Nov 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@SableRaf - I did another fork of the main app and edited the JavaBuild.java file and submitted a second pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsquared
Add all seven of the javafx modules to JavaBuild.java
4613601
Please add _all seven of the javafx modules so that we may use JavaFX controls in our apps. Thanks.
Stefterv
Stefterv suggested changes Nov 17, 2024
View reviewed changes

@Stefterv Stefterv left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vsquared,

Please change the things I marked, I will now look into the JavaFX examples provided and see if they work

Looking at the context of this change as something specific and limited to existing cases handling JavaFX code I think it would probably be fine. I just need to test and understand your use case

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread vsquared-patch-1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread java/src/processing/mode/java/JavaBuild.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

@vsquared
Delete vsquared-patch-1
cb26c90
@Stefterv

Stefterv commented Nov 17, 2024

Copy link
Copy Markdown
Member

Tested on windows, does indeed fix the issue you're describing, so happy to merge after the requested changes.
If you can find a user friendly way, e.g. not just adding the JavaFX jars to the code folder, please let me know. I would like to make that possible.

hx2A reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsquared
Add all seven of the javafx modules to JavaBuild.java
7df7f28
Please add _all seven of the javafx modules so that we may use JavaFX controls in our apps. Thanks.
Stefterv
Stefterv approved these changes Nov 17, 2024
View reviewed changes
@Stefterv

Stefterv commented Nov 17, 2024

Copy link
Copy Markdown
Member

Cool thanks @vsquared!

I'll let you hit the merge button @SableRaf

SableRaf reacted with thumbs up emoji hx2A reacted with hooray emoji villares reacted with heart emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsquared

vsquared commented Nov 17, 2024

Copy link
Copy Markdown
Contributor Author

@Stefterv - If you can find a user friendly way, e.g. not just adding the JavaFX jars to the code folder, please let me know. I would like to make that possible.
On macos if you make the changes I suggested the user should not need to add the jar files to the sketch folder.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SableRaf
SableRaf merged commit 9292eb5 into processing:main Nov 17, 2024
@vsquared
vsquared deleted the patch-1 branch November 17, 2024 14:22
@vsquared

vsquared commented Feb 4, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@Stefterv Pull Request Followup: Thank you for adding the pull request changes. After the last release of the Processing IDE (v. 4.3.2) I have been able to run JavaFX demos on MacOS without adding a 'code' folder to the sketch or modifying/recompiling the editor as I was doing in the past. Because of this success I have started posting new JavaFX demos in the Forum with the anticipation that other users would be able to run them too. Unfortunatey this has not been the case for Windows or Linux users, as discussed here: https://discourse.processing.org/t/processing-and-javafx/45692/6 . They are able to run JavaFX demos, but only after creating a 'code' folder either by drag 'n dropping all seven of the JavaFX jar files onto an open sketch window or manually copy/pasting the jar files which are not easy to find in the 'libraries' folder. It appears that the Processing IDE correctly installs the JavaFX jar files but does not know that they are there and therefore unable to use them. It also appears that this is a known problem and is on the TODO list to fix. I'm willing to help track this down if I know where to start, but I am not a skilled Windows or Linux programmer. I do have Windows 11 and Linux PopOS systems which are rarely used but could be used for testing. Do you have any advice on where to start looking to solve this problem? I appreciate your time and efforts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SableRaf

SableRaf commented Feb 11, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Hi @vsquared. Thanks for your follow-up and for testing on different platforms.

For the JavaFX compatibility issue specifically, I recommend opening a new issue, clarifying the current and intended behavior, as well as any proposed solution(s).

Note: Right now, our main focus is the Gradle migration, which is a major effort with very limited capacity (mostly just @Stefterv working on it). Long term, we are looking at moving away from JOGL and abstracting the renderer—this is part of the roadmap (see issue #881). If you have any thoughts on that and how JavaFX may support that goal, feel free to contribute to the discussion over there.

Appreciate your patience and contributions!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsquared vsquared mentioned this pull request Nov 17, 2025
JavaFX Requires 'code' Folder to Run #1327
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Stefterv Stefterv Stefterv approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add modules for JavaFX Error trying to import JavaFX classes in Processing 4

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vsquared @hx2A @SableRaf @Stefterv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.