GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tests, warehouse: disable egg uploads by woodruffw · Pull Request #14118 · pypi/warehouse

Conversation

@woodruffw

@woodruffw woodruffw commented Jul 13, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

DO NOT MERGE UNTIL AUGUST 1

Also removes the PEP 715 notice emails, since they'll cease to serve any purpose once eggs can't be uploaded.

Closes #10653.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@woodruffw
tests, warehouse: disable egg uploads
6581c04 
Also removes the PEP 715 notice emails, since they'll cease to
serve any purpose once eggs can't be uploaded.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw
woodruffw requested a review from a team as a code owner July 13, 2023 16:15
@woodruffw woodruffw self-assigned this Jul 13, 2023
@woodruffw woodruffw added the blocked Issues we can't or shouldn't get to yet label Jul 13, 2023
@woodruffw woodruffw mentioned this pull request Jul 13, 2023
Deprecate .egg uploads #10653
Closed
@woodruffw
tests: lintage
bc19dfe 
Signed-off-by: William Woodruff <[email protected]>
@di

di commented Jul 13, 2023

Copy link
Copy Markdown
Member

I wonder if we want to provide a specific error message when someone tries to upload an egg indicating that it's deprecated rather than just an invalid file? I think it's probably likely we haven't actually been able to inform everyone that might try to upload an .egg in the future.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@woodruffw

woodruffw commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

@di Were you thinking something beyond this?

https://github.com/pypi/warehouse/pull/14118/files#diff-bffd49e4f943217b54b4cfcf5835737bec7a145360bd1dc2ec1541d2dcafad16L663-R664

That updates the message to include the new PEP as well, but the "Invalid file extension" summary goes to your point about potentially confusing users. I could probably tweak or specialize that error case to emphasize that the error is due to a deprecation, and not an invalid file per se.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@di

di commented Jul 14, 2023

Copy link
Copy Markdown
Member

@woodruffw Ah, I missed that change. I suppose that should be sufficient!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
woodruffw added 2 commits July 17, 2023 18:22
@woodruffw
Merge branch 'main' into tob-de-egg-warehouse
61b5f60
@woodruffw
Merge branch 'main' into tob-de-egg-warehouse
4777638
@woodruffw woodruffw changed the title [DNM] tests, warehouse: disable egg uploads tests, warehouse: disable egg uploads Jul 31, 2023
@woodruffw

woodruffw commented Jul 31, 2023

Copy link
Copy Markdown
Member Author

This is updated and good to go by tomorrow!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
di
di approved these changes Jul 31, 2023
View reviewed changes

@di di left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐣

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
woodruffw reacted with laugh emoji
All reactions
  • 😄 1 reaction
@miketheman

miketheman commented Jul 31, 2023

Copy link
Copy Markdown
Member

Related: pypa/packaging.python.org#1278
woodruffw reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@woodruffw
Merge branch 'main' into tob-de-egg-warehouse
a0a1399
@miketheman miketheman removed the blocked Issues we can't or shouldn't get to yet label Aug 1, 2023
@woodruffw
Merge branch 'main' into tob-de-egg-warehouse
3111476
@woodruffw

woodruffw commented Aug 1, 2023

Copy link
Copy Markdown
Member Author

🍳
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@di
di enabled auto-merge (squash) August 1, 2023 14:21
@di
di merged commit 8643ade into pypi:main Aug 1, 2023
@woodruffw
woodruffw deleted the tob-de-egg-warehouse branch August 1, 2023 14:25
@di di mentioned this pull request Aug 1, 2023
docs: add notice about PEP 715 pypa/packaging.python.org#1278
Merged
@hugovk hugovk mentioned this pull request Aug 24, 2023
PEP 715: Mark as final python/peps#3302
Merged
4 of 6 tasks
@miketheman miketheman mentioned this pull request Aug 21, 2026
chore: only count downloads for the actual artifacts pypi/infra#242
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@di di di approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@woodruffw woodruffw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate .egg uploads

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@woodruffw @di @miketheman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.