GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PEP 715: Mark as final by hugovk · Pull Request #3302 · python/peps

Conversation

@hugovk

@hugovk hugovk commented Aug 24, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive (or canonical-pypa-spec, for packaging PEPs)

I believe this can be marked as final because the PEP has been fully implemented and eggs can no longer be updated to PyPI:

  • Implement initial rollout of PEP 715 pypi/warehouse#14017
  • https://blog.pypi.org/posts/2023-06-26-deprecate-egg-uploads/
  • tests, warehouse: disable egg uploads pypi/warehouse#14118
  • docs: add notice about PEP 715 pypa/packaging.python.org#1278

cc @woodruffw @di

📚 Documentation preview 📚: https://pep-previews--3302.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
PEP 715: Mark as final
c7b9e8c
@hugovk
hugovk requested a review from dstufft as a code owner August 24, 2023 10:41
woodruffw
woodruffw approved these changes Aug 24, 2023
View reviewed changes

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks @hugovk!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
di
di approved these changes Aug 24, 2023
View reviewed changes

@di di left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
AA-Turner merged commit 3bf335b into python:main Aug 24, 2023
@hugovk
hugovk deleted the pep715-mark-as-final branch August 24, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstufft dstufft Awaiting requested review from dstufft
2 more reviewers
@di di di approved these changes
@woodruffw woodruffw woodruffw approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @di @woodruffw @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.