GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Check consistency between merge target and title. · Issue #111 · python/bedevere

Check consistency between merge target and title. #111

New issue
Copy link
New issue
Copy link
Closed
#112
Closed
Check consistency between merge target and title.#111
#112
Copy link

Description

@terryjreedy
terryjreedy
opened on Jun 24, 2018
Issue body actions

python/cpython#7765
is a trivial doc change intended for master, 3.7, 3.6, and 2.7. I reviewed,
approved, marked labels, and after a 2nd approval, merged it. miss-islington
cherry-picked it to 3.7, but failed for 3.6 and 2.7. The author then discovered
that the 3.6 failure was because the original PR was (accidentally) against
3.6, not master.

On core_mentorship, Nick suggested that the best way to catch such an error is for Bedevere to check consistency between between branch merge target (in above case, 3.6) and the presence or absence of a branch label (in above case, none).

"When bedevere checks for the BPO issue reference, it could also check
that the target branch matches the commit message prefix (i.e. if
there's no "[3.6] " at the start, then targetting the 3.6 branch is
wrong - PRs without a version prefix should always be targeting
master, and PRs deliberately targeting a maintenance branch directly
should include the prefix).
"
Possible message:
"If this PR is really for 3.6, prefix [3.6] to the title.
If this PR is for master, CLOSE IT and make a new PR."

Activity

  1. Mariatta commented on Jun 24, 2018

    @Mariatta
    Mariatta
    on Jun 24, 2018
    Member
    More actions

    Duplicate of python/core-workflow#211

  2. Mariatta
    marked this as a duplicate of Bot to check if PR is not against the master branch, and it is not a backport PR core-workflow#211 on Jun 24, 2018
  3. Mariatta
    added a commit that references this issue on Jun 24, 2018

    Post a status check for backport PR title.

    582cd90
  4. Mariatta
    added a commit that references this issue on Jul 21, 2018

    Post a status check for backport PR title.

    7cf3ec8
  5. Mariatta
    closed this as completedin #112on Jul 21, 2018
  6. Mariatta
    added a commit that references this issue on Jul 21, 2018

    Post a status check for backport PR title. (#112)

    fd57148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402520 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.