GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33885: Replace "hook function" with "callable" by andresdelfino · Pull Request #7765 · python/cpython

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Jun 17, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue33885

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andresdelfino
bpo-33885: Replace "hook function" with "callable"
39cd950
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 17, 2018
@bedevere-bot bedevere-bot added the awaiting review label Jun 17, 2018
terryjreedy
terryjreedy approved these changes Jun 22, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 22, 2018
@terryjreedy terryjreedy added needs backport to 3.6 docs Documentation in the Doc dir skip news labels Jun 22, 2018
orsenthil
orsenthil approved these changes Jun 22, 2018
View reviewed changes
@terryjreedy
terryjreedy merged commit c45cb47 into python:3.6 Jun 22, 2018
@miss-islington

miss-islington commented Jun 22, 2018

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2018
@bedevere-bot

bedevere-bot commented Jun 22, 2018

Copy link
Copy Markdown

GH-7861 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jun 22, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2018
@andresdelfino @miss-islington
bpo-33885: Replace "hook function" with "callable" (pythonGH-7765)
14e9787 
(cherry picked from commit c45cb47)

Co-authored-by: Andrés Delfino <[email protected]>
@miss-islington

miss-islington commented Jun 22, 2018

Copy link
Copy Markdown
Contributor

Sorry, @andresdelfino and @terryjreedy, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c45cb479074b5d25f0d382d3109f527520a9f03c 2.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned terryjreedy Jun 22, 2018
@miss-islington

miss-islington commented Jun 22, 2018

Copy link
Copy Markdown
Contributor

Sorry, @andresdelfino and @terryjreedy, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c45cb479074b5d25f0d382d3109f527520a9f03c 3.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Jun 22, 2018

Copy link
Copy Markdown
Member

Andres, the backports are yours if you think them worthwhile. Ditto for 'complete progams', if the issue comes up.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Jun 22, 2018
@miss-islington @andresdelfino
bpo-33885: Replace "hook function" with "callable" (GH-7765)
e4db730 
(cherry picked from commit c45cb47)

Co-authored-by: Andrés Delfino <[email protected]>
@andresdelfino
andresdelfino deleted the patch-3 branch June 23, 2018 02:04
@andresdelfino
andresdelfino restored the patch-3 branch June 23, 2018 02:07
@andresdelfino

andresdelfino commented Jun 23, 2018

Copy link
Copy Markdown
Contributor Author

@terryjreedy

  1. I just noticied I select the wrong branch when making this PR, see that it points to 3.6.
  2. I'll gladly take the backports.
  3. What do you mean by: Ditto for 'complete progams', if the issue comes up.

Regarding the first item, the backport to 3.6 is no need, as the commit has merged into that branch already. I'll make the backport for 2.7. And a forwardport(?) for this to master. Or should we proceed otherwise?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andresdelfino

andresdelfino commented Jun 23, 2018

Copy link
Copy Markdown
Contributor Author

Regarding the third item, I see you were talking about #7744 :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Jun 23, 2018

Copy link
Copy Markdown
Member

There are 3 options. I am going to ask on core_mentorship which is preferred.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andresdelfino

andresdelfino commented Jun 23, 2018

Copy link
Copy Markdown
Contributor Author

OK, I'll wait. Sorry for the inconvenience...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Jun 24, 2018

Copy link
Copy Markdown
Member

On core_mentorship, Nick Coughlin said "Just cherry pick to the full set of destinations from the original
commit rather than trying to revert anything." Go ahead.
He also had idea how Bedevere could catch mistake on submission.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andresdelfino
andresdelfino deleted the patch-3 branch June 24, 2018 01:48
@andresdelfino

andresdelfino commented Jun 24, 2018

Copy link
Copy Markdown
Contributor Author

Great! I'll do it right away. Sorry for the hassle.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Jun 24, 2018
@andresdelfino
[2.7] bpo-33885: Replace "hook function" with "callable" (pythonGH-7765…
537a558 
…).

(cherry picked from commit c45cb47)

Co-authored-by: Andrés Delfino <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 24, 2018

Copy link
Copy Markdown

GH-7885 is a backport of this pull request to the 2.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 2.7 label Jun 24, 2018
@terryjreedy terryjreedy mentioned this pull request Jun 24, 2018
Check consistency between merge target and title. python/bedevere#111
Closed
terryjreedy pushed a commit that referenced this pull request Jun 24, 2018
@andresdelfino @terryjreedy
[2.7] bpo-33885: Replace "hook function" with "callable" (GH-7765). (#…
2c11e23 
…7885)

(cherry picked from commit c45cb47)

Co-authored-by: Andrés Delfino <[email protected]>
andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Jun 24, 2018
@andresdelfino
[master] bpo-33885: Replace "hook function" with "callable" (pythonGH…
460fed8 
…-7765)

(cherry picked from commit c45cb47)

Co-authored-by: Andrés Delfino <[email protected]>
@terryjreedy

terryjreedy commented Jun 24, 2018

Copy link
Copy Markdown
Member

Repositories are intentionally mistake resilient. The guaranteed way to never make a bad merge is to never make a merge. There have been people who have done the latter after getting commit privileges.
We still need a cherry-pick to master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andresdelfino andresdelfino mentioned this pull request Jun 24, 2018
Teach cherry_picker to forwardport to master python/core-workflow#270
Closed
@andresdelfino

andresdelfino commented Jun 24, 2018

Copy link
Copy Markdown
Contributor Author

Oh, I already opened the PR, but it didn't reference this one. LEt me grab the link
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andresdelfino

andresdelfino commented Jun 24, 2018

Copy link
Copy Markdown
Contributor Author

#7886

already committed, though :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
orsenthil pushed a commit that referenced this pull request Jun 24, 2018
@andresdelfino @orsenthil
[master] bpo-33885: Replace "hook function" with "callable" (GH-7765) (…
0ba9a0b 
…#7886)

(cherry picked from commit c45cb47)

Co-authored-by: Andrés Delfino <[email protected]>
@andresdelfino

andresdelfino commented Jun 24, 2018

Copy link
Copy Markdown
Contributor Author

I guess "needs backport to 3.6" tag should be removed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta removed the needs backport to 3.6 label Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes
@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@andresdelfino @miss-islington @bedevere-bot @terryjreedy @orsenthil @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.