GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-428: Add GitHub issue to description of PR by ryanlong1004 · Pull Request #430 · python/bedevere

Conversation

@ryanlong1004

@ryanlong1004 ryanlong1004 commented Apr 13, 2022 •
edited by Mariatta
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #428

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ryanlong1004 added 4 commits April 12, 2022 20:47
@ryanlong1004
add github issue to description of PR
d5f1260
@ryanlong1004
add 'patch' method to fake GH
4407093
@ryanlong1004
update requirements
197d0c3
@ryanlong1004
update testing
2db4b1d
Mariatta
Mariatta requested changes Apr 13, 2022
View reviewed changes
Comment thread bedevere/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread requirements.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/test_gh_issue.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread bedevere/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread bedevere/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
ryanlong1004 added 3 commits April 12, 2022 23:08
@ryanlong1004
return only if body is present as well as issue number
2880a53
@ryanlong1004
Update per PR #430
91af55d
@ryanlong1004
remove unused import
4d9971d
@ryanlong1004
ryanlong1004 requested a review from Mariatta April 13, 2022 03:30
@ambv ambv closed this Apr 13, 2022
@ambv ambv reopened this Apr 13, 2022
@ghost

ghost commented Apr 13, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ryanlong1004
revert
dda9a25
@hugovk

hugovk commented May 2, 2022

Copy link
Copy Markdown
Member

@ryanlong1004 Please can you resolve the conflicts?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ryanlong1004
Merge branch 'master' into 430_add_github_issue_to_description
206b86c
@codecov

codecov Bot commented May 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #430 (b302bf8) into main (77db0d5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #430   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1720      1760   +40     
  Branches       208       213    +5     
=========================================
+ Hits          1720      1760   +40
Flag Coverage Δ
Python_3.10 100.00% <100.00%> (?)
Python_3.11-dev 100.00% <100.00%> (?)
Python_3.8 100.00% <100.00%> (?)
Python_3.9 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bedevere/util.py 100.00% <100.00%> (ø)
tests/test_gh_issue.py 100.00% <100.00%> (ø)
tests/test_stage.py 100.00% <100.00%> (ø)
tests/test_util.py 100.00% <100.00%> (ø)
bedevere/news.py 100.00% <0.00%> (ø)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk mentioned this pull request May 6, 2022
Document auto-closing keywords for PRs. python/devguide#855
Merged
JelleZijlstra
JelleZijlstra reviewed May 6, 2022
View reviewed changes
Comment thread bedevere/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread bedevere/gh_issue.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread bedevere/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/test_gh_issue.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
ryanlong1004 and others added 4 commits May 7, 2022 18:57
@ryanlong1004 @JelleZijlstra
Update bedevere/gh_issue.py
e91bd4b 
Co-authored-by: Jelle Zijlstra <[email protected]>
@ryanlong1004 @JelleZijlstra
Update tests/test_gh_issue.py
1f588f4 
Co-authored-by: Jelle Zijlstra <[email protected]>
@ryanlong1004
remove bpo link
c24ef08
@ryanlong1004
use more specific in test
69d23fb
JelleZijlstra
JelleZijlstra reviewed May 7, 2022
View reviewed changes
Comment thread bedevere/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
ryanlong1004 added 2 commits May 7, 2022 23:32
@ryanlong1004
update tests
ffd8f0f
@ryanlong1004
ensure don't replace existing body
a7463ca
@ryanlong1004
ryanlong1004 requested a review from JelleZijlstra May 7, 2022 23:53
JelleZijlstra
JelleZijlstra reviewed May 8, 2022
View reviewed changes
Comment thread bedevere/util.py
BODY = f"""\
{{body}}
gh-{{issue_number}}
{CLOSING_TAG}

@JelleZijlstra JelleZijlstra May 8, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a closing tag but no opening tag?

I'm not sure what the tag is for, but my best guess is that it's so the bot can reliably recognize that it has already added a link. So maybe we should also add an open tag and use that to check whether to add the issue number.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ryanlong1004 ryanlong1004 May 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from link below. There was no opening tag there.
https://github.com/python/bedevere/blob/3d532cd90271a506ad222af42dbaacb8139c1138/bedevere/bpo.py

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Jun 15, 2022

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JelleZijlstra, can this conversation be resolved?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Jun 15, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code did have an opening tag:

bedevere/bedevere/bpo.py

Line 15 in 3d532cd

<!-- {TAG_NAME}: bpo-{{issue_number}} -->

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Jun 15, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it seems we're not using the tag now. If so, we should remove the closing tag too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ezio-melotti ezio-melotti Jun 15, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tag was added there to make it easier to parse it, e.g. if one day we migrate again.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tests/test_gh_issue.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ryanlong1004
remove stub
fee1fa6
@arhadthedev arhadthedev mentioned this pull request May 17, 2022
Remove typing.io and typing.re python/cpython#92871
Closed
@Mariatta

Mariatta commented May 18, 2022

Copy link
Copy Markdown
Member

Thanks for your work @ryanlong1004!

Would you be able to increase the coverage to 100%?
ryanlong1004 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ryanlong1004
make 100% test coverage
ce253e3
@erlend-aasland erlend-aasland changed the title add github issue to description of PR gh-428: Add GitHub issue to description of PR Jun 15, 2022
@erlend-aasland

erlend-aasland commented Jun 15, 2022

Copy link
Copy Markdown

@Mariatta, you requested changes. Are you happy with the PR as it stands? Please mark it approved, if so.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti
ezio-melotti reviewed Jun 15, 2022
View reviewed changes
Comment thread bedevere/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti
ezio-melotti reviewed Jun 15, 2022
View reviewed changes
Comment thread tests/test_util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti
Add opening tag and bullet list.
8b256bd
ezio-melotti
ezio-melotti reviewed Jun 16, 2022
View reviewed changes
Comment thread bedevere/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/test_util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti
Fix tests.
b302bf8
@ambv
ambv merged commit ad03d53 into python:main Jun 16, 2022
@ryanlong1004
ryanlong1004 deleted the 430_add_github_issue_to_description branch June 22, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@erlend-aasland erlend-aasland erlend-aasland left review comments
@ezio-melotti ezio-melotti ezio-melotti left review comments
@Mariatta Mariatta Awaiting requested review from Mariatta

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add link to the GitHub Issue from the PR

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@ryanlong1004 @hugovk @Mariatta @erlend-aasland @JelleZijlstra @ezio-melotti @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.