GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Rename PR remote option to --pr-remote by ncoghlan · Pull Request #106 · python/core-workflow

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Jun 2, 2017

Copy link
Copy Markdown
Contributor

The new --push/--no-push option conflicts with the old name
of the option for setting the PR remote.

This updates the latter option to the more explicit
--pr-remote.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ncoghlan
Rename PR remote option to --pr-remote
fa790a4 
The new --push/--no-push option conflicts with the old name
of the option for setting the PR remote.

This updates the latter option to the more explicit
`--pr-remote`.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 2, 2017
@ncoghlan

ncoghlan commented Jun 2, 2017

Copy link
Copy Markdown
Contributor Author

Tested by generating python/cpython#1921 and it seems to mostly work.

However, it would be good to remember the PR remote name in the --continue state file: https://github.com/python/core-workflow/issues/107 (I haven't added that yet myself, as I'll need to look into how the command continuation works)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta added the cherry_picker.py label Jun 2, 2017
@brettcannon
brettcannon requested a review from Mariatta June 2, 2017 18:42
Mariatta
Mariatta approved these changes Jun 4, 2017
View reviewed changes
@Mariatta
Mariatta merged commit 0242435 into python:master Jun 4, 2017
@Mariatta

Mariatta commented Jun 4, 2017

Copy link
Copy Markdown
Member

Thanks :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cherry_picker.py CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ncoghlan @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.