GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — cherry-picker: Run Travis CI test on Windows by encukou · Pull Request #311 · python/core-workflow

Conversation

@encukou

@encukou encukou commented Feb 22, 2019

Copy link
Copy Markdown
Member

I've set up a Windows build on Travis before, maybe I can help #296 a bit!
There's no Python pre-installed, but there's a package manager, choco, that can install it.

Currently, the tests fail because they seem to require Git's user.email and user.name to be set globally. They fail on my dev machine as well, since I don't have an e-mail set globally (I use different e-mail addresses on different repos).
Sadly, I can't devote time to fixing that issue, but I can help to reproduce or explain more if needed.

To try out changes privately, here's what I do:

  • Enable Travis on your fork of the repo
  • Uncheck "Build pused branches" and "Build pushed pull requests" on your fork's Travis settings (you'll want to trigger builds manually)
  • Push code you want to test to your fork's master branch
  • Use "Trigger build in Travis's "More options" menu to trigger the build
  • Cancel any builds you're not interested in (for example, all the Linux builds) to save both time and processing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou
cherry-picker: Run Travis CI test on Windows
5eb4d83
Fixes: python#296
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 22, 2019
@encukou encukou mentioned this pull request Feb 22, 2019
Add Windows CI for cherry-picker #296
Closed
webknjaz
webknjaz reviewed Feb 22, 2019
View reviewed changes
Comment thread .travis.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

webknjaz
webknjaz reviewed Feb 22, 2019
View reviewed changes
Comment thread .travis.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Feb 22, 2019

Copy link
Copy Markdown
Member

It should be easy to fix tests by extending this fixture (https://github.com/python/core-workflow/blob/b3c68fe/cherry_picker/cherry_picker/test.py#L87-L91) to set local user and email in config.

Mariatta reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Feb 22, 2019

Copy link
Copy Markdown
Member Author

Oh, one more thing I meant to put in the initial comment:

Unfortunately I probably won't find much time to tend to this PR properly. Feel free to make changes directly to the branch, that'll make things much faster.

webknjaz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Feb 22, 2019

Copy link
Copy Markdown
Member

Another thing is that Travis CI seems to be going down now: ansible/molecule#1770

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz
Use explicit block literal in before_install in Travis
c9a3c8b
webknjaz
webknjaz reviewed Mar 15, 2019
View reviewed changes
Comment thread .travis.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

webknjaz and others added 2 commits March 15, 2019 19:32
@webknjaz
Use declarative way of setting up env vars
3cefad1
@webknjaz
🐛✅ Set up Git user name and email in tests
bcb89e3
@encukou
encukou requested a review from Mariatta as a code owner March 15, 2019 18:43
webknjaz added 2 commits March 15, 2019 19:59
@webknjaz
✅🎨 Use fixtures in find config tests
ae151c6
@webknjaz
✅🎨 Use fixtures in load config tests
0263b57
@webknjaz

webknjaz commented Mar 15, 2019

Copy link
Copy Markdown
Member

Git config related tests fixed. Now, there's two Unicode-related failures.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

webknjaz added 2 commits March 15, 2019 20:17
@webknjaz
🚑Use pathlib's write_text for saving test config
683c3a8
@webknjaz
🚑 Use UTF-8 encoding for saving test config
e7c0d2b
@webknjaz

webknjaz commented Mar 15, 2019

Copy link
Copy Markdown
Member

@Mariatta please merge it, it's ready.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz webknjaz mentioned this pull request Mar 15, 2019
Cherry-picker: Remove BACKPORT_COMPLETE. UNSET state after finished. #315
Merged
Mariatta
Mariatta approved these changes Mar 16, 2019
View reviewed changes
@Mariatta

Mariatta commented Mar 16, 2019

Copy link
Copy Markdown
Member

Thanks!!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Mariatta
Mariatta merged commit 9cf0ac1 into python:master Mar 16, 2019
@Mariatta Mariatta added the cherry_picker.py label May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz left review comments
@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cherry_picker.py CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @webknjaz @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.