GeezerVison

@webknjaz @asvetlov can you take a look. miss-islington is seeing the "BACKPORT_COMPLETE" status, but couldn't continue because it is not an allowed state. I think it should be an allowed state, or did you have different expectation.

Checking it now.

@Mariatta I expected that state would be reset if everything is completed successfully. How about calling reset_state() after line 391 instead?

Any non-allowed states are supposed idicate that something went wrong.

Ok I've removed BACKPORT_COMPLETE. unset will be called instead, and using the UNSET state.

uugh don't know what's the deal with travis 😟 Tests-passing-locally-for-me™️

Oh, that's weird... Did you run all tests locally or just related?

Hmm I ran everything pytest cherry_picker/test.py -v in the cherry_picker directory

I checked this branch locally as well and it passes.

@Mariatta just to be on the safe side, could you please clear the cache in Travis CI? It's here https://travis-ci.org/python/core-workflow/caches

I've cleared cache and restart the build, still no luck 🤕 Anyone else can try this locally?

🐍🌚🤖 @Mariatta, I've formatted these files using black:

• cherry_picker/cherry_picker/cherry_picker.py
• cherry_picker/cherry_picker/test.py
  (I'm a bot 🤖)

@Mariatta could you please merge #311 and then rebase this one? The test suite didn't use new fixtures in some tests and it could improve the situation, I think (hope).

@Mariatta I know what the problem is! 🎉

So git log -r dc896437c8efe5a4a5dfa50218b7a6dc0cbe2598 is executed to check the repo.
But Travis CI only gets 50 last commits by default, not the whole tree. So this commit is now further than 50 commits and the check fails.

Solutions:

1. Change the sha in config to something newer
2. Find &install-and-test-cherry-picker on line 28 in .travis.yml and extend the mapping to contain Git config adjustment:

- &install-and-test-cherry-picker
  ...
  git:
    depth: 200
  ...

🐍🌚🤖 @Mariatta, I've formatted these files using black:

• cherry_picker/cherry_picker/test.py
  (I'm a bot 🤖)

hm, but changing it to recent sha also only delays the problem, same issue will happen again in the future.

🐍🌚🤖 @Mariatta, I've formatted these files using black:

• cherry_picker/cherry_picker/test.py
  (I'm a bot 🤖)

@Mariatta I think you should just make git clone deeper. Or if you're worried about the delay, it's possible to disable --depth= in Travis CI so that it'd clone the whole thing.

🐍🌚🤖 @Mariatta, I've formatted these files using black:

• cherry_picker/cherry_picker/test.py
  (I'm a bot 🤖)

Thanks, I've disabled git depth in travis CI and reverted the mocks.

@Mariatta great!

P.S. One small feedback about black out: as you can see it messes up unrelated stuff making it impossible to track down (by looking at diff) what was the intended change in the PR. It's not completely non-atomic. I'd recommend applying black to the project separately and then when PR is on top of that, using back will only generate related changes :)

Thanks!