Description

mdboom

opened on Dec 9, 2022

Issue body actions

The --enable-pystats system has a couple of important shortcomings:

• When stats is turned off, stats aren't dumped (on quit or explicitly). Therefore, it's impossible to put sys._stats_on/sys._stats_off calls around tested code and get the results out.
• Since stats collection is on by default, it is very fiddly to exclude code for stats, especially for things that fire off subprocesses, e.g. pyperformance.

@markshannon's suggestion is to:

• Having stats off by default
• Add an -Xstats flag to turn it on at startup
• Always dump out stats

Linked PRs

• gh-100143: Improve collecting pystats for parts of runs #100144

Activity

1. mdboom

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Dec 9, 2022
2. markshannon

   added a commit that references this issue on Dec 12, 2022

   GH-100143: Improve collecting pystats for parts of runs (GH-100144)

   1583c6e
3. markshannon commented on Dec 13, 2022

   

   markshannon

   on Dec 13, 2022

   Member

   More actions

   We also need to add a mechanism to always have stats on, for gathering stats for applications which cannot be modified or spawn subprocesses.

   Adding an environment variable analog for -Xstats, e.g. PYTHONSTATS should be sufficient.
4. carljm

   added a commit that references this issue on Dec 14, 2022

   Merge branch 'main' into typedocs

   53d33a1
5. hauntsaninja commented on Dec 24, 2022

   

   hauntsaninja

   on Dec 24, 2022

   Contributor

   More actions

   Thanks, looks like this is completed
6. hauntsaninja

   closed this as completedon Dec 24, 2022

Issue actions