Description

barneygale

opened on Jan 26, 2023

Issue body actions

pathlib.PurePath.match() doesn't use fnmatch() to match path anchors, contrary to the documentation. Instead, it considers the drive and root of the pattern separately; if either (or both) is specified in the pattern, it must exactly match the corresponding drive/root in the path.

This results in the following:

>>> from pathlib import PureWindowsPath as P
>>> P('c:/b.py').match('*:/*.py')
False
>>> P('c:/b.py').match('c:*.py')
True
>>> P('c:/b.py').match('/*.py')
True
>>> P('//some/share/a.py').match('//*/*/*.py')
False
>>> P('//some/share/a.py').match('/*.py')
True

All of these results are wrong IMO.

Linked PRs

• gh-101360: Fix anchor matching in pathlib.PureWindowsPath.match() #101363

Activity

1. barneygale

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   3.11only security fixesonly security fixes

   3.10 (EOL)end of lifeend of life

   3.12only security fixesonly security fixes

   topic-pathlib

   on Jan 26, 2023
2. AlexWaygood

   added

   OS-windows

   on Jan 26, 2023
3. barneygale commented on Jan 27, 2023

   

   barneygale

   on Jan 27, 2023

   ContributorAuthor

   More actions

   I think I know why this behaviour is here: pathlib originally wouldn't parse patterns like *:/ because it required drive letters to be alphabetic. match() worked around this by treating empty drives like *.

   The alphabetic drive requirement was removed in 2ba0fd5 (3.12).
4. barneygale

   added 3 commits that reference this issue on Jan 27, 2023

   pythongh-101360: Fix anchor matching in pathlib.PureWindowsPath.match()

   85b8e4c

   pythongh-101360: Fix anchor matching in pathlib.PureWindowsPath.match()

   13e9330

   Merge branch 'main' into pythongh-101360-fix-match-partial-anchor

   ef53ea0
5. zooba

   added a commit that references this issue on Feb 17, 2023

   gh-101360: Fix anchor matching in pathlib.PureWindowsPath.match() (GH…

   d401b20
6. barneygale commented on Feb 17, 2023

   

   barneygale

   on Feb 17, 2023

   ContributorAuthor

   More actions

   Fixed in #101363 / d401b20
7. barneygale

   closed this as completedon Feb 17, 2023

Issue actions