Description

colesbury

opened on Jan 30, 2023

Issue body actions

In the main branch, the function _tracemalloc__get_object_traceback doesn't account for objects with preheaders:

cpython/Modules/_tracemalloc.c

Lines 1406 to 1414 in ea23271

	type = Py_TYPE(obj);
	if (PyType_IS_GC(type)) {
	ptr = (void *)((char *)obj - sizeof(PyGC_Head));
	}
	else {
	ptr = (void *)obj;
	}
	traceback = tracemalloc_get_traceback(DEFAULT_DOMAIN, (uintptr_t)ptr);

This means that when running with tracemalloc some allocation tracebacks are missing:

import warnings

class MyClass:
    def __del__(self):
        warnings.warn("Uh oh", ResourceWarning, source=self)

def func():
    m = MyClass()

func()

python3 -Wd -X tracemalloc=2 example.py

cc @markshannon

Linked PRs

• gh-101430: Update tracemalloc to handle presize properly. #101745

Activity

1. colesbury

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   3.12only security fixesonly security fixes

   on Jan 30, 2023
2. colesbury commented on Jan 30, 2023

   

   colesbury

   on Jan 30, 2023

   ContributorAuthor

   More actions

   Also _PyTraceMalloc_NewReference:

   cpython/Modules/_tracemalloc.c

   Lines 1726 to 1733 in 28db978

   	uintptr_t ptr;
   	PyTypeObject *type = Py_TYPE(op);
   	if (PyType_IS_GC(type)) {
   	ptr = (uintptr_t)((char *)op - sizeof(PyGC_Head));
   	}
   	else {
   	ptr = (uintptr_t)op;
   	}
3. corona10

   added 3 commits that reference this issue on Feb 9, 2023

   pythongh-101430: Update tracemalloc to handle presize properly.

   f3808bf

   pythongh-101430: Update tracemalloc to handle presize properly.

   6b451fa

   gh-101430: Update tracemalloc to handle presize properly. (gh-101745)

   5b946d3
4. corona10

   closed this as completedon Feb 9, 2023
5. carljm

   added a commit that references this issue on Feb 10, 2023

   Merge branch 'main' into inlinecomp2

   add772e
6. vstinner commented on Apr 5, 2023

   

   vstinner

   on Apr 5, 2023

   Member

   More actions

   If someone is motivated, it would be nice to add an unit test to test_tracemalloc for this case.
7. zhuyifei1999

   added 2 commits that reference this issue on May 13, 2023

   hv_cli_prod.c: Fix producer profile for Python 3.11

   b1af54e

   hv_cli_prod.c: Fix producer profile for Python 3.11

   e80cafb

Issue actions