Description

corona10

opened on Feb 2, 2023

Issue body actions

Using a BOLT still not guarantee the unexpected behavior changes.
For example, I observed that #53093 is raised if the binary is optimized by BOLT.
We can reduce several too aggressive optimization.

• Optimizing BOLT flags #128514
• Choose the APIs that should not be optimized BOLT (e.g -skip-funcs)
• Update libregrtest.utils.get_build_info()
• Update make test to work correctly (Should skip the BOLT phase if the binary is already BOLTed)
• Define minimum LLVM version
• Enhance the BOLT build process #101282
• Test BOLT builds in CI #128515

cc @aaupov

Linked PRs

• gh-101525: Disable peephole optimization process of BOLT #103187
• gh-101525: Fix make test if the --enable-bolt enabled #103574
• gh-101525: Skip test_gdb if the binary is relocated by BOLT. #118572
• [3.13] gh-101525: Skip test_gdb if the binary is relocated by BOLT. (gh-118572) #123601
• [3.12] gh-101525: Skip test_gdb if the binary is relocated by BOLT. (… #123603
• gh-101525: Use only safe identical code folding with BOLT #134642
• gh-101525: [BOLT] Add GCC's LTO-generated function clones, with computed gotos, to BOLT skip list #139840
• gh-101525: configure: Add PIE detection logic for BOLT optimizations compatibility #140203
• gh-101525: Check whether to skip functions with computed gotos during BOLT runs #140250

Activity

1. corona10

   added

   type-featureA feature request or enhancementA feature request or enhancement

   performancePerformance or resource usagePerformance or resource usage

   on Feb 2, 2023
2. corona10

   self-assigned this

   on Feb 2, 2023
3. corona10 commented on Feb 2, 2023

   

   corona10

   on Feb 2, 2023

   MemberAuthor

   More actions

   I am analyzing several effects of BOLT.
4. corona10 commented on Feb 8, 2023

   

   corona10

   on Feb 8, 2023

   MemberAuthor

   More actions

   Need to update get_build_info for the BOLT binary.
5. corona10 commented on Feb 24, 2023

   

   corona10

   on Feb 24, 2023

   MemberAuthor

   More actions

   Consider a way to detect post-bolted binary: llvm/llvm-project#60253
6. corona10

   added 2 commits that reference this issue on Apr 2, 2023

   pythongh-101525: Disable peephole optimization process of BOLT

   16f15a1

   gh-101525: Disable peephole optimization process of BOLT (gh-103187)

   a62ff97
7. gaogaotiantian

   added a commit that references this issue on Apr 8, 2023

   pythongh-101525: Disable peephole optimization process of BOLT (pytho…

   1614139
8. warsaw

   added a commit that references this issue on Apr 11, 2023

   pythongh-101525: Disable peephole optimization process of BOLT (pytho…

   9ca78d7
9. corona10

   added 2 commits that reference this issue on Apr 16, 2023

   pythongh-101525: Fix make test if the --enable-bolt enabled

   a9a36d5

   gh-101525: Fix make test if the --enable-bolt enabled (gh-103574)

   5d9762e
10. indygreg

    added 2 commits that reference this issue on May 20, 2023

    pythongh-101282: rework the BOLT build process

    f7851cd

    pythongh-101282: rework the BOLT build process

    555686d
11. erlend-aasland

    added a commit that references this issue on May 22, 2023

    gh-101282: Apply BOLT optimizations to libpython for shared builds (#…

    5360cb3
12. 8 remaining items
13. corona10

    added 2 commits that reference this issue on Sep 2, 2024

    [3.12] pythongh-101525: Skip test_gdb if the binary is relocated by B…

    1ba223c

    [3.12] gh-101525: Skip test_gdb if the binary is relocated by BOLT. (… (

    4514998
14. zanieb commented on Feb 9, 2025

    

    zanieb

    on Feb 9, 2025

    Contributor

    More actions

    Let's talk about next steps for stabilization here? We have testing in CI now and I think x86-64 can be considered stable?
15. corona10 commented on Feb 10, 2025

    

    corona10

    on Feb 10, 2025

    MemberAuthor

    More actions

    Yeah, I think that we can close this issue at this moment :)
16. geofft commented on May 25, 2025

    

    geofft

    on May 25, 2025

    Contributor

    More actions

    Using a BOLT still not guarantee the unexpected behavior changes.
    For example, I observed that #53093 is raised if the binary is optimized by BOLT.

    #134642 should address this.
17. stratakis

    added 3 commits that reference this issue on Oct 17, 2025

    pythongh-101525: Check whether to skip functions with computed gotos …

    5c600a6

    pythongh-101525: Add GCC's LTO-generated function clones, with comput…

    d6da34f

    pythongh-101525: Check whether to skip functions with computed gotos …

    241a541
18. corona10

    added a commit that references this issue on Oct 19, 2025

    gh-101525: [BOLT] Add GCC's LTO-generated function clones, with compu…

    bad8d6d
19. stratakis commented on Nov 6, 2025

    

    stratakis

    on Nov 6, 2025

    Contributor

    More actions

    Crash on Fedora 43 reported on llvm: llvm/llvm-project#166863
20. stratakis

    added 2 commits that reference this issue on Nov 20, 2025

    pythongh-101525: Check whether to skip functions with computed gotos …

    41d3a75

    pythongh-101525: Check whether to skip functions with computed gotos …

    33effce
21. StanFromIreland

    added a commit that references this issue on Dec 6, 2025

    pythongh-101525: [BOLT] Add GCC's LTO-generated function clones, with…

    0685971
22. stratakis

    added 2 commits that reference this issue on Dec 17, 2025

    fixup! pythongh-101525: Check whether to skip functions with computed…

    944072e

    fixup! pythongh-101525: Check whether to skip functions with computed…

    336f8ed

Issue actions