Description

skirpichev

opened on Mar 20, 2023

Issue body actions

Sometimes input checks are missing (e.g. L989 of math_1 or L1023 of math_1a), sometimes exceptional cases are not tested (e.g. in fsum), some code is just inaccessible (like L3519 in the perm_comb_small() helper). See attached coverage report (for ./python -m test test_math).

I believe, everything should be tested (except for memory errors and similar special cases).

lcov-report.zip

Linked PRs

• gh-102837: few coverage nitpicks for the math module #102523
• gh-102837: Increase test coverage for the math module #110000
• gh-102837: more tests for the math module #111930
• [3.12] gh-102837: more tests for the math module (GH-111930) #112029
• [3.12] gh-102837: more tests for the math module (GH-111930)(GH-102523) #112030
• [3.11] gh-102837: more tests for the math module (GH-111930)(GH-102523) (GH-112030) #112041

Activity

1. skirpichev

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on Mar 20, 2023
2. AlexWaygood

   added

   testsTests in the Lib/test dirTests in the Lib/test dir

   on Mar 20, 2023
3. skirpichev

   added a commit that references this issue on Mar 20, 2023

   pythongh-102837: few coverage nitpicks for the math module

   68b2e42
4. hauntsaninja

   added a commit that references this issue on Sep 3, 2023

   gh-102837: improve test coverage for math module (#102523)

   9c995ab
5. hauntsaninja

   closed this as completedon Sep 3, 2023
6. skirpichev commented on Sep 3, 2023

   

   skirpichev

   on Sep 3, 2023

   MemberAuthor

   More actions

   @hauntsaninja, wait. As I said in the PR thread - there are still some uncovered lines/branches. I think it's worth to keep this issue open until it's fixed completely.
7. hauntsaninja

   reopened this on Sep 3, 2023
8. hauntsaninja commented on Sep 3, 2023

   

   hauntsaninja

   on Sep 3, 2023

   Contributor

   More actions

   Ah, missed that since it was early on. Re-opened!
9. skirpichev

   added 2 commits that reference this issue on Sep 28, 2023

   pythongh-102837: Increase test coverage for the math module

   a635952

   pythongh-102837: Increase test coverage for the math module

   a1d2c1a
10. skirpichev

    added a commit that references this issue on Nov 10, 2023

    pythongh-102837: more tests for the math module

    459dee2
11. encukou

    added a commit that references this issue on Nov 13, 2023

    gh-102837: more tests for the math module (GH-111930)

    c61de45
12. skirpichev

    added a commit that references this issue on Nov 13, 2023

    [3.12] pythongh-102837: more tests for the math module (pythonGH-111930)

    fc30aed
13. encukou

    added 5 commits that reference this issue on Nov 13, 2023

    pythongh-102837: more tests for the math module (pythonGH-111930)

    3650c8d

    pythongh-102837: improve test coverage for math module (python#102523) (

    42d1d23

    pythongh-102837: more tests for the math module (pythonGH-111930)

    b549dc5

    [3.12] gh-102837: more tests for the math module (GH-111930)(GH-102523)…

    c6aea46

    [3.11] gh-102837: more tests for the math module (GH-111930)(GH-102523)…

    132a749
14. aisk

    added a commit that references this issue on Feb 11, 2024

    pythongh-102837: more tests for the math module (pythonGH-111930)

    6ee62a5
15. Glyphack

    added a commit that references this issue on Sep 2, 2024

    pythongh-102837: more tests for the math module (pythonGH-111930)

    91e7113
16. skirpichev

    closed this as not plannedon Oct 25, 2024

Issue actions