Description

art049

opened on Apr 20, 2023

Issue body actions

Bug report

As implemented by @pablogsal in #96123 we can now generate perf maps(which is awesome BTW).
Currently, perf maps are formatted this way:

0x58c5882 b py::<module>:/home/arthur/Projects/python-playground/dummy_script.py
0x58c588d b py::baz:/home/arthur/Projects/python-playground/dummy_script.py
0x58c5898 b py::bar:/home/arthur/Projects/python-playground/dummy_script.py
0x58c58a3 b py::foo:/home/arthur/Projects/python-playground/dummy_script.py

However, as per the perf maps interface specification it seems the address should not include the leading 0x.

Thus the perf map should look like this:

58c5882 b py::<module>:/home/arthur/Projects/python-playground/dummy_script.py
58c588d b py::baz:/home/arthur/Projects/python-playground/dummy_script.py
58c5898 b py::bar:/home/arthur/Projects/python-playground/dummy_script.py
58c58a3 b py::foo:/home/arthur/Projects/python-playground/dummy_script.py

Still, it works fine with perf but might not with other tools not handling this leading 0x.

Your environment

• CPython versions tested on: 3.12.0a7
• Operating system and architecture: Manjaro 22.1.0 x86_64

Linked PRs

• gh-103650: Fix perf maps address format #103651

Reacted by sunmy2019

Activity

1. art049

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Apr 20, 2023
2. arhadthedev

   added

   3.12only security fixesonly security fixes

   3.13only security fixesonly security fixes

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   on Apr 20, 2023
3. terryjreedy commented on Apr 20, 2023

   

   terryjreedy

   on Apr 20, 2023

   Member

   More actions

   @pablogsal The perf doc says that perf map start addresses (as well as sizes) are hex numbers without '0x'. The implementation prints them with '0x'. Which is wrong? There is a PR to change the implementation.
4. pablogsal

   added a commit that references this issue on May 7, 2023

   gh-103650: Fix perf maps address format (#103651)

   8d95012
5. hauntsaninja commented on May 8, 2023

   

   hauntsaninja

   on May 8, 2023

   Contributor

   More actions

   Closing since #103651 was merged
6. hauntsaninja

   closed this as completedon May 8, 2023
7. jbower-fb

   added a commit that references this issue on May 8, 2023

   pythongh-103650: Fix perf maps address format (python#103651)

   44914e0
8. carljm

   added a commit that references this issue on May 9, 2023

   Merge branch 'main' into inlinecomp2

   76077cd

Issue actions