Description

corona10

opened on May 1, 2023

Issue body actions

cpython/Modules/gcmodule.c

Lines 1391 to 1402 in 4b27972

	for (Py_ssize_t i=0; i<PyList_GET_SIZE(gcstate->callbacks); i++) {
	PyObject *r, *cb = PyList_GET_ITEM(gcstate->callbacks, i);
	Py_INCREF(cb); /* make sure cb doesn't go away */
	r = PyObject_CallFunction(cb, "sO", phase, info);
	if (r == NULL) {
	PyErr_WriteUnraisable(cb);
	}
	else {
	Py_DECREF(r);
	}
	Py_DECREF(cb);
	}

The phase object can be created earlier with one-time creation and it can be replaced with vectorcall either.
From my microbenchmark, there is 4-5% performance improvement by doing this.

microbenchmark

import pyperf
import gc


def benchamark_collection(loops):
    def callback_foo(phase, info):
        pass
    for _ in range(100):
        gc.callbacks.append(callback_foo)

    total_time = 0
    for _ in range(loops):
        t0 = pyperf.perf_counter()
        collected = gc.collect()
        total_time += pyperf.perf_counter() - t0
    return total_time


if __name__ == "__main__":
    runner = pyperf.Runner()
    runner.metadata["description"] = "GC callback benchmark"
    runner.bench_time_func("create_gc_cycles", benchamark_collection)

Linked PRs

• gh-104028: Reduce object creation while calling callback function from gc #104030

Reacted by Ken Jin

Reacted by Ken Jin

Activity

1. corona10

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on May 1, 2023
2. corona10

   added a commit that references this issue on May 1, 2023

   pythongh-104028: Reduce objects creation while calling callback funct…

   6977273
3. corona10

   changed the title [-]Reduce redundant phase objects while calling callback function on gc[/-] [+]Reduce redundant object creation while calling callback function on gc[/+] on May 1, 2023
4. corona10

   added

   performancePerformance or resource usagePerformance or resource usage

   and removed

   type-featureA feature request or enhancementA feature request or enhancement

   on May 1, 2023
5. corona10

   added a commit that references this issue on May 1, 2023

   pythongh-104028: Reduce objects creation while calling callback funct…

   47534f3
6. corona10

   changed the title [-]Reduce redundant object creation while calling callback function on gc[/-] [+]Reduce redundant object creation while calling callback function from gc[/+] on May 1, 2023
7. corona10

   added 2 commits that reference this issue on May 1, 2023

   pythongh-104028: Reduce objects creation while calling callback funct…

   d55c1a1

   gh-104028: Reduce object creation while calling callback function fro…

   e147694
8. corona10

   closed this as completedon May 1, 2023
9. carljm

   added 2 commits that reference this issue on May 1, 2023

   Merge branch 'main' into supermon

   159b2aa

   Merge branch 'main' into inlinecomp2

   1274e2b

Issue actions