Description

Eclips4

opened on May 13, 2023

Issue body actions

Tried on last commit

PS C:\Users\KIRILL-1\CLionProjects\cpython> ./python -m test -R 3:3 test_exceptions
Running Debug|x64 interpreter...
0:00:00 Run tests sequentially
0:00:00 [1/1] test_exceptions
beginning 6 repetitions
123456
......
test_exceptions leaked [18, 18, 18] references, sum=54
test_exceptions leaked [12, 12, 12] memory blocks, sum=36
test_exceptions failed (reference leak) in 38.1 sec

== Tests result: FAILURE ==

1 test failed:
    test_exceptions

Total duration: 38.2 sec
Tests result: FAILURE

OS: Windows 10

Linked PRs

• gh-104454: Fix refleak in AttributeError_reduce #104455

Activity

1. Eclips4

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on May 13, 2023
2. iritkatriel commented on May 13, 2023

   

   iritkatriel

   on May 13, 2023

   Member

   More actions

   More specifically:

   % ./python.exe -m test -R3:3 test_exceptions -m testAttributes 
   Raised RLIMIT_NOFILE: 256 -> 1024
   0:00:00 load avg: 3.46 Run tests sequentially
   0:00:00 load avg: 3.46 [1/1] test_exceptions
   beginning 6 repetitions
   123456
   ......
   test_exceptions leaked [18, 18, 18] references, sum=54
   test_exceptions leaked [12, 12, 12] memory blocks, sum=36
   test_exceptions failed (reference leak)
   
   == Tests result: FAILURE ==
   
   1 test failed:
       test_exceptions
   
   Total duration: 256 ms
   Tests result: FAILURE
   
   

   Reacted by Kirill Podoprigora
3. csm10495 commented on May 13, 2023

   

   csm10495

   on May 13, 2023

   Contributor

   More actions

   PR opened to fix. Thanks folks. For my benefit: Why doesn't this test run on PRs?
4. AlexWaygood commented on May 13, 2023

   

   AlexWaygood

   on May 13, 2023

   Member

   More actions

   PR opened to fix. Thanks folks. For my benefit: Why doesn't this test run on PRs?

   Running the refleak tests generally takes a while, and isn't necessary for most PRs to CPython. We have a label we can add to PRs to trigger the test being run; in this case, looks like we just forgot to add that label to this PR. It's not a big issue; happens quite often around here :-)

   Reacted by Charles Machalow, Gregory P. Smith and Erlend E. Aasland
5. gpshead

   added a commit that references this issue on May 13, 2023

   gh-104454: Fix refleak in AttributeError_reduce (#104455)

   7d2deaf
6. gpshead commented on May 13, 2023

   

   gpshead

   on May 13, 2023

   Member

   More actions

   thanks for the fix. I missed this leak in review (easy for anyone to miss - our C API is full of sharp edges) and didn't think to trigger the refleaks buildbots on the original PR. it happens, no worries.
7. gpshead

   closed this as completedon May 13, 2023
8. carljm

   added 2 commits that reference this issue on May 15, 2023

   Merge branch 'main' into supermon

   343867a

   Merge branch 'main' into cached_property_docs

   452d9f5

Issue actions