Description

iritkatriel

opened on May 19, 2023

Issue body actions

pymarshal_write_long_to_file and pymarshal_write_object_to_file pretend that PyMarshal_WriteLongToFile/PyMarshal_WriteObjectToFile can set an error.

pymarshal_read_last_object_from_file and pymarshal_read_object_from_file don't check for errors so they can call Py_BuildValue with a NULL arg.

Linked PRs

• gh-104645: fix error handling in marshal tests #104646
• [3.11] gh-104645: fix error handling in marshal tests (GH-104646) #104663

Activity

1. iritkatriel

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   testsTests in the Lib/test dirTests in the Lib/test dir

   on May 19, 2023
2. iritkatriel

   added 2 commits that reference this issue on May 19, 2023

   pythongh-104645: fix error handling in marshal tests

   19b2600

   Revert "pythongh-104645: fix error handling in marshal tests"

   e9978b8
3. iritkatriel

   closed this as completedin #104646on May 19, 2023
4. iritkatriel

   added a commit that references this issue on May 19, 2023

   gh-104645: fix error handling in marshal tests (#104646)

   ac56a85
5. miss-islington

   added a commit that references this issue on May 19, 2023

   pythongh-104645: fix error handling in marshal tests (pythonGH-104646)

   e1768d9
6. iritkatriel

   added a commit that references this issue on May 19, 2023

   [3.11] gh-104645: fix error handling in marshal tests (GH-104646) (#1…

   d78c3bc
7. carljm

   added a commit that references this issue on May 20, 2023

   Merge branch 'main' into gsallam/main

   ea5965a

Issue actions