Description

iritkatriel

opened on Jun 1, 2023

Issue body actions

As discussed in capi-workgroup/problems#20, there are functions in the C API that do not have a way to report error (void return type).

Some of them actually set the error indicator in some cases, and the only way to know it to check PyErr_Occurred(). In other cases the functions currently do not have error cases, but the lack of return value is still a problem in case we want to evolve them in the future and need to report errors.

We will use this issue to fix the straightforward ones, while more complicated ones may spawn their own issues.

Linked PRs

• gh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred #105185
• [3.12] gh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (GH-105185) #105218
• [3.11] gh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (GH-105185) #105219
• [3.10] gh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (GH-105185) #105220
• [3.9] gh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (GH-105185) #105221
• [3.8] gh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (GH-105185) #105222
• [3.7] gh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (GH-105185) #105223
• gh-105184: add return value indicating success/failure for PyMarshal_WriteLongToFile and PyMarshal_WriteObjectToFile #105233

Reacted by sunmy2019

Activity

1. iritkatriel

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Jun 1, 2023
2. iritkatriel

   added a commit that references this issue on Jun 1, 2023

   pythongh-105184: document that marshal functions can fail and need to…

   212c72e
3. AlexWaygood

   added

   topic-C-API

   on Jun 1, 2023
4. iritkatriel

   added a commit that references this issue on Jun 2, 2023

   gh-105184: document that marshal functions can fail and need to be ch…

   ee26ca1
5. miss-islington

   added 5 commits that reference this issue on Jun 2, 2023

   pythongh-105184: document that marshal functions can fail and need to…

   5ce8704

   pythongh-105184: document that marshal functions can fail and need to…

   743390a

   pythongh-105184: document that marshal functions can fail and need to…

   d86fa18

   pythongh-105184: document that marshal functions can fail and need to…

   45c7dec

   pythongh-105184: document that marshal functions can fail and need to…

   20b6755
6. iritkatriel

   added 4 commits that reference this issue on Jun 2, 2023

   [3.12] gh-105184: document that marshal functions can fail and need t…

   46cc4f0

   [3.11] gh-105184: document that marshal functions can fail and need t…

   8de607a

   pythongh-105184: add return value indicating success/failure for PyMa…

   57f890c

   pythongh-105184: add return value indicating success/failure for PyMa…

   c5cf75c
7. ned-deily

   added a commit that references this issue on Jun 5, 2023

   [3.7] gh-105184: document that marshal functions can fail and need to…

   32590d5
8. ambv

   added 3 commits that reference this issue on Jun 5, 2023

   [3.8] gh-105184: document that marshal functions can fail and need to…

   c43c50e

   [3.9] gh-105184: document that marshal functions can fail and need to…

   e1c396d

   [3.10] gh-105184: document that marshal functions can fail and need t…

   f12502b
9. carlosroman

   added a commit that references this issue on Jun 22, 2023

   Upgrade to 3.8.17 (#26)

   e0a363f
10. iritkatriel

    closed this as completedon Jul 25, 2023

Issue actions