Description

gvanrossum

opened on Jun 9, 2023

Issue body actions

There are some tests for the cases generator in Tools/cases_generator/test_generator.py, but several things are wrong with these:

• They are currently broken
• They depend on pytest
• They aren't run in CI
• They are incomplete

Let's fix that (in that order).

Linked PRs

• gh-105540: Fix code generator tests #105707
• gh-105540: Convert pytest tests of cases_generator to regular tests #106713
• gh-105540: Show source files relative to root #106927
• gh-105540: Improve relative paths in generate_cases.py #106942

Activity

1. gvanrossum

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Jun 9, 2023
2. gvanrossum

   added a commit that references this issue on Jun 12, 2023

   gh-105540: Fix code generator tests (#105707)

   8da9d1b
3. carljm

   added a commit that references this issue on Jun 12, 2023

   Merge branch 'main' into modulelocals

   2fae889
4. gvanrossum

   added

   easy

   on Jul 13, 2023
5. gvanrossum commented on Jul 13, 2023

   

   gvanrossum

   on Jul 13, 2023

   MemberAuthor

   More actions

   This should be pretty easy -- just Python code. Especially the next step (removing the pytest dependency in favor of unittest) should be quite doable.
6. sobolevn

   added a commit that references this issue on Jul 13, 2023

   pythongh-105540: Convert `pytest` tests of `cases_generator` to regul…

   96ebd50
7. gvanrossum

   added 2 commits that reference this issue on Jul 16, 2023

   gh-105540: Convert `pytest` tests of `cases_generator` to regular tes…

   c413207

   gh-105540: Show source files relative to root (#106927)

   1218910
8. sobolevn

   added a commit that references this issue on Jul 21, 2023

   pythongh-105540: Improve relative paths in `generate_cases.py`

   7445cf8
9. gvanrossum commented on Jul 31, 2023

   

   gvanrossum

   on Jul 31, 2023

   MemberAuthor

   More actions

   Honestly I think we can close this issue, making the tests comprehensive will just be an ongoing task, it's not a bug.
10. gvanrossum

    closed this as completedon Jul 31, 2023

Issue actions