GeezerVison is showing github.com — ctypes: Deprecate SetPointerType() and ARRAY() functions · Issue #105733 · python/cpython
ctypes: Deprecate SetPointerType() and ARRAY() functions #105733DescriptionThe ctypes module has two undocumented functions: SetPointerType() and ARRAY(). These functions are marked as XXX Deprecated, but only in comments.
I propose to deprecate ctypes.SetPointerType() and ctypes.ARRAY() by emitting a DeprecationWarning warning.
These functions are not documented and not used in Python, but there are tested.
Linked PRs
Activityencukou commented on Jul 25, 2024 I disagree with the proposal. (And with taking one hour between a proposal and merge.)
The plan to remove ARRAY in 3.15 goes against PEP 387:
If the expected maintenance overhead and security risk of the deprecated behavior is small (e.g. an old function is reimplemented in terms of a new, more general one), it can stay indefinitely (or until the situation changes).
(I'll note that this clarification got added a few days after this proposal, though.)
The function is two lines long, and has tests. It has no maintenance overhead or additional security risk.
It's also used in third-party projects (some of which test with alphas/betas and have now switched to multiplication).
I propose to restore it and soft-deprecate instead. Would you be OK with that, @vstinner?
As for SetPointerType, yeah, no one should be using that, and hardly anyone is. encukou commented on Jul 25, 2024 (anecdotally: at EuroPython I've seen a person use ARRAY in the REPL. This is not worth them re-learning how to make array types.) vstinner commented on Jul 27, 2024 I didn't see any complain about the deprecation apart from you. I don't see the benefits of keeping two ways to create an array. PEP 20 says:
There should be one-- and preferably only one --obvious way to do it.
A code search on PyPI top 7,500 projects only finds 2 lines:
PYPI-2024-03-16/astroid-3.1.0.tar.gz: astroid-3.1.0/tests/brain/test_ctypes.py: ctypes.ARRAY(3, 2)
PYPI-2024-03-16/pwntools-4.12.0.tar.gz: pwntools-4.12.0/pwnlib/adb/bootloader.py: imgarray = ctypes.ARRAY(img_info, self.num_images)
The first one is stupid, ctypes.ARRAY(3, 2) returns 6... The first parameter must be a ctypes type, not an integer. picnixz commented on Jul 28, 2024 encukou commented on Jul 29, 2024 So it's PEP 20 against PEP 387, or your opinion against mine :( JelleZijlstra commented on Jul 29, 2024 I would favor keeping ARRAY, since there is little maintenance cost involved and removing it would break at least some users. picnixz commented on Jul 29, 2024 I personally like ARRAY because it tells you that are you are creating an array (visually speaking) vstinner commented on Jul 29, 2024 encukou commented on Jul 29, 2024 I'm for soft deprectation, because it tells you which of the two ways to do it is the obvious one :) added a commit that references this issue on Jul 30, 2024gh-105733: Soft-deprecate ctypes.ARRAY, rather than hard-deprecating … picnixz commented on Jul 30, 2024 Closing since completed in #122281.
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|