Description

AlexWaygood

opened on Jun 15, 2023

Issue body actions

Bug report

Following #105801, test___all__.AllTest.test_all is failing on every non-docs PR on the "Hypothesis tests on Ubuntu" CI job.

The traceback is:

======================================================================
FAIL: test_all (test.test___all__.AllTest.test_all)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test___all__.py", line 129, in test_all
    self.check_all(modname)
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test___all__.py", line 43, in check_all
    with warnings_helper.check_warnings(
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/contextlib.py", line 144, in __exit__
    next(self.gen)
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/support/warnings_helper.py", line 185, in _filterwarnings
    raise AssertionError("unhandled warning %s" % reraise[0])
AssertionError: unhandled warning {message : SyntaxWarning("invalid escape sequence '\\?'"), category : 'SyntaxWarning', filename : '/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_httpservers.py', lineno : 445, line : None}

Example failures:

• https://github.com/python/cpython/actions/runs/5277208289/jobs/9544938249
• https://github.com/python/cpython/actions/runs/5274715744/jobs/9539462432?pr=105794
• https://github.com/python/cpython/actions/runs/5272447172/jobs/9534727485

This failure was visible in the CI for #105801 FYI

Linked PRs

• gh-105821: Use a raw f-string in test_httpservers.py #105822
• [3.12] gh-105821: Use a raw f-string in test_httpservers.py (GH-105822) #105824
• [3.11] gh-105821: Use a raw f-string in test_httpservers.py (GH-105822) #108576
• [3.10] gh-105821: Use a raw f-string in test_httpservers.py (GH-105822) #115519

Activity

1. AlexWaygood

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Jun 15, 2023
2. AlexWaygood

   assigned

   pablogsal

   on Jun 15, 2023
3. pablogsal commented on Jun 15, 2023

   

   pablogsal

   on Jun 15, 2023

   Member

   More actions

   This failure was visible in the CI for #105801 FYI

   But then how is possible that we could land that PR?
4. pablogsal commented on Jun 15, 2023

   

   pablogsal

   on Jun 15, 2023

   Member

   More actions

   Ah, because hypothesis tests are not mandatory. Well, this is what I feared that would happen having non-mandatory tests that are already failing for other reasons 😞
5. AlexWaygood commented on Jun 15, 2023

   

   AlexWaygood

   on Jun 15, 2023

   MemberAuthor

   More actions

   Ah, because hypothesis tests are not mandatory.

   Indeed

   Well, this is what I feared that would happen having non-mandatory tests that are already failing for other reasons 😞

   FWIW, I haven't seen any failures on the "hypothesis tests" job since @ericsnowcurrently fixed the test__xxsubinterpreter and test_threading crashes. We could probably make it a "required" CI check at this point.
6. pablogsal commented on Jun 15, 2023

   

   pablogsal

   on Jun 15, 2023

   Member

   More actions

   We could probably make it a "required" CI check at this point.

   I think we should
7. AlexWaygood commented on Jun 15, 2023

   

   AlexWaygood

   on Jun 15, 2023

   MemberAuthor

   More actions

   We could probably make it a "required" CI check at this point.

   I think we should

   We should probably continue discussion on the matter at #86275
8. pablogsal

   added a commit that references this issue on Jun 15, 2023

   gh-105821: Use a raw f-string in test_httpservers.py (#105822)

   09ce8c3
9. miss-islington

   added a commit that references this issue on Jun 15, 2023

   pythongh-105821: Use a raw f-string in test_httpservers.py (pythonGH-…

   82d4d81
10. AlexWaygood

    added a commit that references this issue on Jun 15, 2023

    [3.12] gh-105821: Use a raw f-string in test_httpservers.py (GH-105822)…

    3073e23
11. AlexWaygood

    closed this as completedon Jun 15, 2023
12. AlexWaygood commented on Jun 15, 2023

    

    AlexWaygood

    on Jun 15, 2023

    MemberAuthor

    More actions

    Thanks for the quick fix @pablogsal!!
13. carljm

    added a commit that references this issue on Jun 15, 2023

    Merge branch 'main' into modulelocals

    166aca9
14. lazka

    added 2 commits that reference this issue on Jul 19, 2023

    pythongh-105821: Use a raw f-string in test_httpservers.py (python#10…

    8e4bd54

    pythongh-105821: Use a raw f-string in test_httpservers.py (python#10…

    920c434
15. lazka

    added 2 commits that reference this issue on Aug 25, 2023

    pythongh-105821: Use a raw f-string in test_httpservers.py (python#10…

    1abab23

    pythongh-105821: Use a raw f-string in test_httpservers.py (python#10…

    0a6c9de
16. miss-islington

    added a commit that references this issue on Aug 28, 2023

    pythongh-105821: Use a raw f-string in test_httpservers.py (pythonGH-…

    bab5694
17. AlexWaygood

    added a commit that references this issue on Aug 28, 2023

    [3.11] gh-105821: Use a raw f-string in test_httpservers.py (GH-105822)…

    ed749be
18. miss-islington

    added a commit that references this issue on Feb 15, 2024

    pythongh-105821: Use a raw f-string in test_httpservers.py (pythonGH-…

    a40720a
19. pablogsal

    added a commit that references this issue on Feb 16, 2024

    [3.10] gh-105821: Use a raw f-string in test_httpservers.py (GH-105822)…

    6091fbd

Issue actions