Description

iritkatriel

opened on Sep 7, 2023

Issue body actions

frame->prev_instr has confusing semantics, we will replace it by a new field instr_ptr which is

(1) the instruction currently executing (if any), or
(2) the next instruction to execute on the frame (otherwise).

Linked PRs

• gh-109094: replace frame->prev_instr by frame->instr_ptr #109095
• gh-109094: remove unnecessary updates of frame->prev_instr in instrumentation functions #109076
• gh-109094: remove redundant arg to _PyFrame_PushTrampolineUnchecked #110759

Reacted by Ken Jin

Activity

1. iritkatriel

   self-assigned this

   on Sep 7, 2023
2. iritkatriel

   added

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   on Sep 7, 2023
3. iritkatriel

   added a commit that references this issue on Sep 7, 2023

   gh-109094: remove unnecessary updates of frame->prev_instr in instrum…

   9639696
4. markshannon

   added a commit that references this issue on Oct 12, 2023

   gh-109094: remove redundant arg to _PyFrame_PushTrampolineUnchecked (G…

   7dd3c2b
5. iritkatriel

   added a commit that references this issue on Oct 26, 2023

   gh-109094: replace frame->prev_instr by frame->instr_ptr (#109095)

   67a91f7
6. iritkatriel

   closed this as completedon Oct 26, 2023
7. aisk

   added a commit that references this issue on Feb 11, 2024

   pythongh-109094: replace frame->prev_instr by frame->instr_ptr (pytho…

   bc7df6b
8. Glyphack

   added 2 commits that reference this issue on Sep 2, 2024

   pythongh-109094: remove redundant arg to _PyFrame_PushTrampolineUnche…

   9264ed7

   pythongh-109094: replace frame->prev_instr by frame->instr_ptr (pytho…

   feb4455

Issue actions