GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — pystats should save all metadata necessary to perform comparison in pystats .json output · Issue #109373 · python/cpython

pystats should save all metadata necessary to perform comparison in pystats .json output #109373

New issue
Copy link
New issue
Copy link
Closed
Closed
pystats should save all metadata necessary to perform comparison in pystats .json output#109373
Copy link
Labels
type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

@mdboom
mdboom
opened on Sep 13, 2023
Issue body actions

Bug report

Bug description:

The Tools/scripts/summarize_stats.py script currently has the ability to save stats to a .json file so that collected stats can later be compared to another set of collected stats. Unfortunately, this comparison must be performed on the same version of Python that collected the stats, since information about specialized instructions and stats types are collected at runtime during the comparison (from the opcode module and by scraping the source code). Failure to do so may either break, or, worse, silently create incorrect results. If this information was instead stored in the .json file, the comparison could be formed on any recent enough build of Python, which is particularly important for the benchmarking infrastructure, where we don't want to have to checkout or rebuild specific versions of Python just to create derived comparative data.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

  • gh-109373: Store metadata required for pystats comparison in the json #109374

Activity

  1. mdboom
    added
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    on Sep 13, 2023
  2. mdboom
    added a commit that references this issue on Sep 13, 2023

    pythongh-109373: Store metadata required for pystats comparison in th…

    db0687f
  3. brandtbucher
    added a commit that references this issue on Sep 15, 2023

    GH-109373: Store metadata required for pystats comparison in the JSON (…

    19f5eff
  4. brandtbucher
    closed this as completedon Sep 22, 2023
  5. csm10495
    added a commit that references this issue on Sep 28, 2023

    pythonGH-109373: Store metadata required for pystats comparison in th…

    287a3fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.