Description

colesbury

opened on Sep 29, 2023

Issue body actions

Bug report

On Linux and macOS, test_cppext fails due to:

AssertionError: would build wheel with unsupported tag ('cp313', 'cp313td', 'linux_x86_64')

Example build: https://buildbot.python.org/all/#/builders/1217/builds/286

Resolving this failure will require updating pip and our bundled pip version. In the meantime, I will skip this test on --disable-gil builds.

On Windows, there are additional build failures (test_importlib, test_peg_generator)

AssertionError: '_d.cp313-win32.pyd' not found in ['_d.cp313t-win_amd64.pyd', '_d.pyd']

LINK : fatal error LNK1181: cannot open input file 'python313_d.lib'

Example build: https://buildbot.python.org/all/#/builders/1241/builds/18

Resolving the Windows test failures require #110049 so that we have a standard way of determining --disable-gil builds from Python code.

Linked PRs

• gh-110119: Temporarily skip test_cppext on --disable-gil builds. #110123
• gh-110119: Fix test_importlib --disable-gil Windows test failures #110422
• Revert "gh-110119: Temporarily skip test_cppext on --disable-gil builds. (#110123)" #116964

Activity

1. colesbury

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   testsTests in the Lib/test dirTests in the Lib/test dir

   3.13only security fixesonly security fixes

   on Sep 29, 2023
2. colesbury

   self-assigned this

   on Sep 29, 2023
3. colesbury

   added a commit that references this issue on Sep 29, 2023

   pythongh-110119: Temporarily skip test_cppext on --disable-gil builds.

   d071615
4. carljm

   added a commit that references this issue on Sep 29, 2023

   gh-110119: Temporarily skip test_cppext on --disable-gil builds. (#11…

   2973970
5. colesbury

   added a commit that references this issue on Oct 5, 2023

   pythongh-110119: Fix test_importlib `--disable-gil` Windows test fail…

   2ebec1f
6. vstinner

   added a commit that references this issue on Oct 5, 2023

   gh-110119: Fix test_importlib `--disable-gil` Windows test failures (#…

   3c2f321
7. colesbury commented on Oct 5, 2023

   

   colesbury

   on Oct 5, 2023

   ContributorAuthor

   More actions

   These are fixed now. The Windows buildbot needed to not be run from the "Developer Command Prompt for VS 2022".
8. colesbury

   closed this as completedon Oct 5, 2023
9. colesbury commented on Oct 5, 2023

   

   colesbury

   on Oct 5, 2023

   ContributorAuthor

   More actions

   Oops I was looking at the wrong green icon.
10. colesbury

    reopened this on Oct 5, 2023
11. vstinner commented on Oct 5, 2023

    

    vstinner

    on Oct 5, 2023

    Member

    More actions

    [test_cppext] Resolving this failure will require updating pip and our bundled pip version. In the meantime, I will skip this test on --disable-gil builds.

    If pip is fixed, can the test upgrade pip if running NoGIL Python, as a temporary workaround?
12. colesbury commented on Oct 5, 2023

    

    colesbury

    on Oct 5, 2023

    ContributorAuthor

    More actions

    Pip's not fixed yet, but that might be possible once it's fixed. I just put up a PR pypa/packaging#728 to update packaging.tags and then that would need to be pulled into pip's vendored copy of packaging.
13. vstinner commented on Oct 6, 2023

    

    vstinner

    on Oct 6, 2023

    Member

    More actions

    Until pip is fixed, sure, you can skip test_cppext on NoGIL build.
14. colesbury commented on Oct 6, 2023

    

    colesbury

    on Oct 6, 2023

    ContributorAuthor

    More actions

    The Windows test looks like it's passing now.
15. colesbury

    closed this as completedon Oct 6, 2023
16. colesbury

    added a commit that references this issue on Mar 18, 2024

    Revert "pythongh-110119: Temporarily skip test_cppext on --disable-gi…

    a74c8da
17. Glyphack

    added 2 commits that reference this issue on Sep 2, 2024

    pythongh-110119: Temporarily skip test_cppext on --disable-gil builds. (

    fd3b9da

    pythongh-110119: Fix test_importlib `--disable-gil` Windows test fail…

    d2501d2

Issue actions