Description

skirpichev

opened on Oct 26, 2023

Issue body actions

cpython/Modules/mathmodule.c

Line 2835 in 3f84a19

} else if (q_type_float && (PyLong_CheckExact(p_i) || PyBool_Check(q_i))) {

Obviously, should be p_i in the last OR operand, c.f. L2824.

Factored out from #110000. I think this should be fixed regardless on the fate of that pr. 052d7de has also simple test for this if.

Linked PRs

• gh-111342: fix typo in math.sumprod #111416
• [3.12] gh-111342: fix typo in math.sumprod (GH-111416) #111419

Activity

1. rhettinger commented on Oct 28, 2023

   

   rhettinger

   on Oct 28, 2023

   Contributor

   More actions

   @skirpichev Care to make a PR with test for this?
2. skirpichev

   added a commit that references this issue on Oct 28, 2023

   pythongh-111342: fix typo in math.sumprod

   b24fc2e
3. skirpichev commented on Oct 28, 2023

   

   skirpichev

   on Oct 28, 2023

   MemberAuthor

   More actions

   Yep. #111416
4. rhettinger

   added a commit that references this issue on Oct 28, 2023

   gh-111342: fix typo in math.sumprod (GH-111416)

   9dc4fb8
5. miss-islington

   added a commit that references this issue on Oct 28, 2023

   pythongh-111342: fix typo in math.sumprod (pythonGH-111416)

   5d8d11a
6. rhettinger

   closed this as completedon Oct 28, 2023
7. rhettinger

   added a commit that references this issue on Oct 28, 2023

   [3.12] gh-111342: fix typo in math.sumprod (GH-111416) (gh-111419)

   c3f75b7
8. iritkatriel

   added a commit that references this issue on Oct 29, 2023

   pythongh-111342: fix typo in math.sumprod (pythonGH-111416)

   1b70f83
9. aisk

   added a commit that references this issue on Feb 11, 2024

   pythongh-111342: fix typo in math.sumprod (pythonGH-111416)

   5d7f466
10. Glyphack

    added a commit that references this issue on Sep 2, 2024

    pythongh-111342: fix typo in math.sumprod (pythonGH-111416)

    c464851

Issue actions