Description

ntessore

opened on Oct 26, 2023

Issue body actions

Bug report

Bug description:

The public io.text_encoding() function is missing from io.__all__.

>>> import io
>>> "text_encoding" in io.__all___
False

CPython versions tested on:

3.10, 3.11, 3.12

Operating systems tested on:

macOS

Linked PRs

• gh-111356: Add missing documented objects to io.__all__ #111370
• [3.12] gh-111356: io: Add missing documented objects to io.__all__ (GH-111370) #111935
• [3.11] gh-111356: io: Add missing documented objects to io.__all__ (GH-111370) #111936

Activity

1. ntessore

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Oct 26, 2023
2. AlexWaygood

   added

   topic-IO

   on Oct 26, 2023
3. AlexWaygood commented on Oct 26, 2023

   

   AlexWaygood

   on Oct 26, 2023

   Member

   More actions

   The function was added in #19481, by @methane. It looks to me like this was just an accidental omission, rather than something that's been deliberately excluded from __all__. Want to make a PR to add it? :)

   Possibly we could also add a test to Lib/test/test_io.py similar to this one, so that we assert that all public module members are included in __all__:

   cpython/Lib/test/test_inspect/test_inspect.py

   Lines 125 to 126 in b0699aa

   	def test__all__(self):
   	support.check__all__(self, inspect, not_exported=("modulesbyfile",))
4. methane

   added a commit that references this issue on Nov 10, 2023

   gh-111356: io: Add missing documented objects to io.__all__ (#111370)

   baeb771
5. miss-islington

   added 2 commits that reference this issue on Nov 10, 2023

   pythongh-111356: io: Add missing documented objects to io.__all__ (py…

   1a19825

   pythongh-111356: io: Add missing documented objects to io.__all__ (py…

   27e953f
6. methane

   added 2 commits that reference this issue on Nov 10, 2023

   gh-111356: io: Add missing documented objects to io.__all__ (GH-111370)

   0e45786

   gh-111356: io: Add missing documented objects to io.__all__ (GH-111370)

   95141aa
7. hugovk commented on Dec 11, 2023

   

   hugovk

   on Dec 11, 2023

   Member

   More actions

   Fixed and backported, thanks for the issue!

   Reacted by Alex Waygood
8. hugovk

   closed this as completedon Dec 11, 2023
9. aisk

   added a commit that references this issue on Feb 11, 2024

   pythongh-111356: io: Add missing documented objects to io.__all__ (py…

   ac51ff2
10. Glyphack

    added a commit that references this issue on Sep 2, 2024

    pythongh-111356: io: Add missing documented objects to io.__all__ (py…

    e734d54

Issue actions