Description

serhiy-storchaka

opened on Nov 12, 2023

Issue body actions

Feature or enhancement

Signature can be manually added for some builtin functions and classes that do not use Argument Clinic.

Linked PRs

• gh-111999: Add signatures and improve docstrings for builtins #112000
• gh-111999: Fix the signature of str.format_map() #119540
• [3.13] gh-111999: Fix the signature of str.format_map() (GH-119540) #119543

Activity

1. serhiy-storchaka

   added

   type-featureA feature request or enhancementA feature request or enhancement

   docsDocumentation in the Doc dirDocumentation in the Doc dir

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   3.13only security fixesonly security fixes

   on Nov 12, 2023
2. serhiy-storchaka

   added a commit that references this issue on Nov 12, 2023

   pythongh-111999: Add signatures and improve docstrings for builtins

   65d3c75
3. serhiy-storchaka commented on Nov 12, 2023

   

   serhiy-storchaka

   on Nov 12, 2023

   MemberAuthor

   More actions

   This change exposed a bug in a test: #112001.
4. serhiy-storchaka

   added a commit that references this issue on Nov 13, 2023

   gh-111999: Add signatures and improve docstrings for builtins (GH-112000

   1d75ef6
5. serhiy-storchaka

   closed this as completedon Nov 14, 2023
6. aisk

   added a commit that references this issue on Feb 11, 2024

   pythongh-111999: Add signatures and improve docstrings for builtins (p…

   151b318
7. JelleZijlstra commented on May 24, 2024

   

   JelleZijlstra

   on May 24, 2024

   Member

   More actions

   The signature for .format_map() is now incorrect:

   >>> str.format_map.__text_signature__
   '($self, /, mapping)'
   >>> "x".format_map(mapping={})
   Traceback (most recent call last):
     File "<python-input-1>", line 1, in <module>
       "x".format_map(mapping={})
       ~~~~~~~~~~~~~~^^^^^^^^^^^^
   TypeError: str.format_map() takes no keyword arguments
   

   Reacted by Alex Waygood, Serhiy Storchaka and Erlend E. Aasland
8. JelleZijlstra

   reopened this on May 24, 2024
9. JelleZijlstra

   added

   release-blocker

   on May 24, 2024
10. ezio-melotti

    added this to Release and Deferred blockers 🚫on May 24, 2024
11. github-project-automation

    moved this to Todo in Release and Deferred blockers 🚫on May 24, 2024
12. serhiy-storchaka

    added a commit that references this issue on May 25, 2024

    pythongh-111999: Fix the signature of str.format_map()

    0858169
13. serhiy-storchaka commented on May 25, 2024

    

    serhiy-storchaka

    on May 25, 2024

    MemberAuthor

    More actions

    Thank you for catching this @JelleZijlstra.
14. JelleZijlstra

    added a commit that references this issue on May 25, 2024

    gh-111999: Fix the signature of str.format_map() (#119540)

    08e6543
15. miss-islington

    added a commit that references this issue on May 25, 2024

    pythongh-111999: Fix the signature of str.format_map() (pythonGH-119540)

    e809618
16. JelleZijlstra

    added a commit that references this issue on May 25, 2024

    [3.13] gh-111999: Fix the signature of str.format_map() (GH-119540) (#…

    f49749c
17. encukou commented on May 28, 2024

    

    encukou

    on May 28, 2024

    Member

    More actions

    Is there more to do here?
18. JelleZijlstra

    closed this as completedon May 28, 2024
19. github-project-automation

    moved this from Todo to Done in Release and Deferred blockers 🚫on May 28, 2024
20. JelleZijlstra commented on May 28, 2024

    

    JelleZijlstra

    on May 28, 2024

    Member

    More actions

    Thanks @serhiy-storchaka for the quick fix!
21. estyxx

    added a commit that references this issue on Jul 17, 2024

    pythongh-111999: Fix the signature of str.format_map() (python#119540)

    5dd63d9
22. Glyphack

    added a commit that references this issue on Sep 2, 2024

    pythongh-111999: Add signatures and improve docstrings for builtins (p…

    a7d16d9

Issue actions