GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-77102: site: try utf-8 and fallback to locale encoding when reading pth file by methane · Pull Request #117802 · python/cpython

Conversation

@methane

@methane methane commented Apr 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: .pth files cannot contain folders with utf-8 names #77102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
site: try utf-8 and fallback to locale encoding
9e22e88
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 12, 2024
.pth files cannot contain folders with utf-8 names #77102
Closed
hauntsaninja
hauntsaninja approved these changes Apr 14, 2024
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 14, 2024
vstinner
vstinner approved these changes Apr 15, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe document the change https://docs.python.org/dev/whatsnew/3.13.html#improved-modules for more visibility.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
methane added 2 commits April 15, 2024 22:15
@methane
add trace for fallback encoding use
4a09f06
@methane
update docs
72985c1
vstinner
vstinner approved these changes Apr 15, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
fix typo
88f857b
@methane
methane merged commit 6dc661b into python:main Apr 16, 2024
@methane
methane deleted the utf8-pth-file branch April 16, 2024 03:56
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 16, 2024
@bedevere-app

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117917 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane added a commit to methane/cpython that referenced this pull request Apr 16, 2024
@methane
[3.12] pythongh-77102: site: try utf-8 and fallback to locale encodin…
8f81901 
…g when reading .pth file (pythonGH-117802)

(cherry picked from commit 6dc661b)

Co-authored-by: Inada Naoki <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117918 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117917 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117918 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane added a commit that referenced this pull request Apr 16, 2024
@methane
gh-77102: site: try utf-8 and locale encoding when reading .pth file (G…
2a58923 
…H-117802)

(cherry picked from commit 6dc661b)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@methane @diegorusso
pythongh-77102: site: try utf-8 and fallback to locale encoding when …
b99f984 
…reading .pth file (python#117802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@methane @vstinner @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.