Description

ericsnowcurrently

opened on May 25, 2024

Issue body actions

Crash report

Bug description:

gh-118532 added an assert that is erroneously triggers if PyState_FindModule() is called before the provided module def has been initialized. The assert should be removed. (Python/import.c, line 460)

See ultrajson/ultrajson#629.

CPython versions tested on:

3.13, CPython main branch

Operating systems tested on:

No response

Linked PRs

• gh-119560: Drop an Invalid Assert in PyState_FindModule() #119561
• [3.13] gh-119560: Drop an Invalid Assert in PyState_FindModule() (gh-119561) #119632

Activity

1. ericsnowcurrently

   added

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   type-crashA hard crash of the interpreter, possibly with a core dumpA hard crash of the interpreter, possibly with a core dump

   3.13only security fixesonly security fixes

   3.14bugs and security fixesbugs and security fixes

   on May 25, 2024
2. ericsnowcurrently

   self-assigned this

   on May 25, 2024
3. ericsnowcurrently

   added a commit that references this issue on May 25, 2024

   gh-119560: Drop an Invalid Assert in PyState_FindModule() (gh-119561)

   0c5ebe1
4. ericsnowcurrently

   closed this as completedon May 25, 2024
5. mgorny commented on May 26, 2024

   

   mgorny

   on May 26, 2024

   Contributor

   More actions

   Thanks. I can confirm that after applying this on top of 3.13.0b1, ujson passes all tests.
6. miss-islington

   added a commit that references this issue on May 27, 2024

   pythongh-119560: Drop an Invalid Assert in PyState_FindModule() (pyth…

   f7e1d05
7. ericsnowcurrently

   added a commit that references this issue on May 27, 2024

   [3.13] gh-119560: Drop an Invalid Assert in PyState_FindModule() (gh-…

   bd9983c
8. estyxx

   added a commit that references this issue on Jul 17, 2024

   pythongh-119560: Drop an Invalid Assert in PyState_FindModule() (pyth…

   c3cff43

Issue actions