GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve `_xxtestfuzz/README.rst` · Issue #121023 · python/cpython

Improve _xxtestfuzz/README.rst #121023

New issue
Copy link
New issue
Copy link
Closed
Closed
Improve _xxtestfuzz/README.rst#121023
Copy link
Assignees
sobolevn
Labels
docsDocumentation in the Doc dirDocumentation in the Doc dirtestsTests in the Lib/test dirTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Jun 26, 2024
Issue body actions

Bug report

Right now there are several points I would like to see improved in this file:

  1. We need to clarify that $test_name should be replaced with an actual test name:

    cpython/Modules/_xxtestfuzz/README.rst

    Lines 26 to 29 in 8223544

    int $test_name (const char* data, size_t size) {
    ...
    return 0;
    }
  2. _Py_FUZZ_YES is not actually used in our code, docs:

    cpython/Modules/_xxtestfuzz/README.rst

    Line 34 in 8223544

    #if _Py_FUZZ_YES(fuzz_builtin_float)
    code:

    cpython/Modules/_xxtestfuzz/fuzzer.c

    Line 699 in 7fb32e0

    #if !defined(_Py_FUZZ_ONE) || defined(_Py_FUZZ_fuzz_elementtree_parsewhole)
  3. Why is fuzz_builtin_float is used in this example? https://github.com/python/cpython/blob/82235449b85165add62c1b200299456a50a1d097/Modules/_xxtestfuzz/README.rst#L34C9-L34C41 It is better to use $test_name. Or even better $fuzz_test_name to have a common prefix.

Linked PRs

  • gh-121023: Improve _xxtestfuzz/README.rst #121024
  • [3.13] gh-121023: Improve _xxtestfuzz/README.rst (GH-121024) #124140
  • [3.12] gh-121023: Improve _xxtestfuzz/README.rst (GH-121024) #124141

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    testsTests in the Lib/test dirTests in the Lib/test dir
    docsDocumentation in the Doc dirDocumentation in the Doc dir
    on Jun 26, 2024
  2. sobolevn
    self-assigned this
    on Jun 26, 2024
  3. sobolevn
    added a commit that references this issue on Jun 26, 2024

    pythongh-121023: Improve `_xxtestfuzz/README.rst`

    f98e567
  4. sobolevn
    added a commit that references this issue on Sep 16, 2024

    gh-121023: Improve `_xxtestfuzz/README.rst` (#121024)

    a9c2bc1
  5. miss-islington
    added 2 commits that reference this issue on Sep 16, 2024

    pythongh-121023: Improve `_xxtestfuzz/README.rst` (pythonGH-121024)

    d62392f

    pythongh-121023: Improve `_xxtestfuzz/README.rst` (pythonGH-121024)

    95fb45f
  6. sobolevn
    added a commit that references this issue on Sep 16, 2024

    [3.12] gh-121023: Improve `_xxtestfuzz/README.rst` (GH-121024) (#124141)

    446203e
  7. savannahostrowski
    added a commit that references this issue on Sep 22, 2024

    pythongh-121023: Improve `_xxtestfuzz/README.rst` (python#121024)

    9728c97
  8. Yhg1s
    added a commit that references this issue on Sep 24, 2024

    [3.13] gh-121023: Improve `_xxtestfuzz/README.rst` (GH-121024) (#124140)

    9d21c46
  9. hugovk commented on Jan 7, 2025

    @hugovk
    hugovk
    on Jan 7, 2025
    Member
    More actions

    PR merged and backported 🚀

  10. hugovk
    closed this as completedon Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @sobolevn
    sobolevn

Labels

docsDocumentation in the Doc dirDocumentation in the Doc dirtestsTests in the Lib/test dirTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.