Description

colesbury

opened on Jul 10, 2024

Issue body actions

Bug report

The polling objects returned by select.poll and related functions are not thread-safe in the free-threaded build.

The fix might be as simple as adding critical sections to the functions on pollObject or it may require more work.

The following test exercises the thread-unsafe behavior:

• ./python -m test test_poll -m test_threaded_poll

Relevant object:

cpython/Modules/selectmodule.c

Lines 434 to 441 in 3ec719f

	typedef struct {
	PyObject_HEAD
	PyObject *dict;
	int ufd_uptodate;
	int ufd_len;
	struct pollfd *ufds;
	int poll_running;
	} pollObject;

Linked PRs

• gh-121592: Make select.poll() and related objects thread-safe #121594
• [3.13] gh-121592: Make select.poll() and related objects thread-safe (GH-121594) #121623

Activity

1. colesbury

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   3.13only security fixesonly security fixes

   topic-free-threading

   3.14bugs and security fixesbugs and security fixes

   on Jul 10, 2024
2. colesbury

   added 3 commits that reference this issue on Jul 10, 2024

   pythongh-121592: Make select.poll() and related objects thread-safe

   5086314

   pythongh-121592: Make select.poll() and related objects thread-safe

   8b90a6c

   gh-121592: Make select.poll() and related objects thread-safe (#121594)

   44937d1
3. miss-islington

   added a commit that references this issue on Jul 11, 2024

   pythongh-121592: Make select.poll() and related objects thread-safe (p…

   2d82c2f
4. colesbury

   added a commit that references this issue on Jul 11, 2024

   [3.13] gh-121592: Make select.poll() and related objects thread-safe (G…

   3b5f8d2
5. colesbury

   closed this as completedon Jul 11, 2024
6. estyxx

   added a commit that references this issue on Jul 17, 2024

   pythongh-121592: Make select.poll() and related objects thread-safe (p…

   d424609

Issue actions