GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — 3.13.0rc1 regression in PyEval_GetLocals(): `SystemError: Objects/dictobject.c:3774: bad argument to internal function` · Issue #122728 · python/cpython

3.13.0rc1 regression in PyEval_GetLocals(): `SystemError: Objects/dictobject.c:3774: bad argument to internal function` #122728

New issue

Copy link

New issue

Copy link

Closed

3.13.0rc1 regression in PyEval_GetLocals(): SystemError: Objects/dictobject.c:3774: bad argument to internal function#122728

Copy link

Labels

3.13only security fixesonly security fixes3.14bugs and security fixesbugs and security fixestype-crashA hard crash of the interpreter, possibly with a core dumpA hard crash of the interpreter, possibly with a core dump

Description

mgorny

opened

on Aug 6, 2024

Issue body actions

Crash report

What happened?

After upgrading to CPython 3.13.0rc1, the gpgme test suite started failing. The tests fail with errors resembling:

Traceback (most recent call last):
  File "/tmp/gpgme-1.23.2/lang/python/tests/./final.py", line 24, in <module>
    import support
  File "/tmp/gpgme-1.23.2/lang/python/tests/support.py", line 60, in <module>
    assert_gpg_version((2, 1, 12))
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/tmp/gpgme-1.23.2/lang/python/tests/support.py", line 35, in assert_gpg_version
    c.engine_info.version).group(0)
    ^^^^^^^^^^^^^
  File "/tmp/gpgme-1.23.2/lang/python/python3.13-gpg/lib.linux-x86_64-cpython-313/gpg/core.py", line 1352, in engine_info
    infos = [i for i in self.get_engine_info() if i.protocol == p]
                        ~~~~~~~~~~~~~~~~~~~~^^
  File "/tmp/gpgme-1.23.2/lang/python/python3.13-gpg/lib.linux-x86_64-cpython-313/gpg/core.py", line 1366, in get_engine_info
    return gpgme.gpgme_ctx_get_engine_info(self.wrapped)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/tmp/gpgme-1.23.2/lang/python/python3.13-gpg/lib.linux-x86_64-cpython-313/gpg/gpgme.py", line 880, in gpgme_ctx_get_engine_info
    return _gpgme.gpgme_ctx_get_engine_info(ctx)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "<frozen importlib._bootstrap>", line 649, in parent
SystemError: Objects/dictobject.c:3774: bad argument to internal function
FAIL: final.py

I've been able to bisect it to 233ed46 (#121869). However, on this commit I'm getting also a bunch of python3.13: Objects/typeobject.c:5257: _PyType_LookupRef: Assertion '!PyErr_Occurred()' failed. — they are fixed in some subsequent commit. But the final.py failure occurs from that commit to tip of 3.13 (fe65a8b).

Now, gpgme's build system is horrible. To reproduce, I've done the following:

Built CPython with --with-assertions.
Created ln -s python python3.13 symlink in the build directory.
Installed the gpgme C library 1.23.2 using the system package manager.
Then:

wget https://www.gnupg.org/ftp/gcrypt/gpgme/gpgme-1.23.2.tar.bz2
tar -xf gpgme-1.23.2.tar.bz2
cd gpgme-1.23.2
export PATH=${CPYTHON_BUILD_DIRECTORY}:$PATH
./configure  # will probably need some -dev packages
cd lang/python
make PYTHONS=python3.13 check

Note that in order to rebuild, you need to rm -rf python3.13-gpg.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Output from running 'python -VV' on the command line:

Python 3.13.0rc1 (main, Aug 2 2024, 18:56:30) [GCC 14.2.0]

Linked PRs

Reacted by Edgar Ramírez Mondragón

Activity

mgorny
added
type-crashA hard crash of the interpreter, possibly with a core dumpA hard crash of the interpreter, possibly with a core dump
on Aug 6, 2024
thesamesam commented on Aug 6, 2024
thesamesam
on Aug 6, 2024
Contributor
More actions
cc @gaogaotiantian @ncoghlan
hroncok commented on Aug 6, 2024
hroncok
on Aug 6, 2024
Contributor
More actions
We see this in Fedora as well.

https://bugzilla.redhat.com/show_bug.cgi?id=2303107

gpgme built with Python 3.13.0b4 exhibits the same behavior when run on Python 3.13.0rc1.
hroncok commented on Aug 6, 2024
hroncok
on Aug 6, 2024
Contributor
More actions

Built CPython with --with-assertions.

Should not be necessary. We build Python without and the same SystemError happens.

vstinner commented on Aug 6, 2024

vstinner

on Aug 6, 2024

Member

More actions

The problem is that PyDict_Update() is called with NULL as the first argument. It's a regression in PyEval_GetLocals().

gdb traceback:

(gdb) where
#0  dict_merge (interp=0x983f60 <_PyRuntime+88192>, a=a@entry=0x0, b=b@entry=0x7ffff7b34b50, override=override@entry=1) at Objects/dictobject.c:3796
#1  0x00000000004ece12 in PyDict_Update (a=a@entry=0x0, b=b@entry=0x7ffff7b34b50) at Objects/dictobject.c:3887
#2  0x0000000000607cbe in PyEval_GetLocals () at Python/ceval.c:2492
#3  0x00007ffff77ce622 in _gpg_wrap_result (fragile=fragile@entry=0x7ffff7835940, classname=classname@entry=0x7ffff77d05ab "EngineInfo") at python3.13-gpg/helpers.c:318

(gdb) frame 3
#3  0x00007ffff77ce622 in _gpg_wrap_result (fragile=fragile@entry=0x7ffff7835940, classname=classname@entry=0x7ffff77d05ab "EngineInfo") at python3.13-gpg/helpers.c:318
318	      results = PyImport_ImportModuleLevel("results", PyEval_GetGlobals(),
319	                                           PyEval_GetLocals(), from_list, 1);

(gdb) frame 2
#2  0x0000000000607cbe in PyEval_GetLocals () at Python/ceval.c:2492
2492	        if (PyDict_Update(ret, locals) < 0) {

(gdb) l 2488
2483	        PyObject *ret = f->f_locals_cache;
2484	        if (ret == NULL) {
2485	            PyObject *ret = PyDict_New();
2486	            if (ret == NULL) {
2487	                Py_DECREF(locals);
2488	                return NULL;
2489	            }
2490	            f->f_locals_cache = ret;
2491	        }
2492	        if (PyDict_Update(ret, locals) < 0) {

(gdb) p ret
$1 = (PyObject *) 0x0
(gdb) p locals
$2 = (PyObject *) 0x7ffff7b34b50

vstinner
added 3 commits that reference this issue on Aug 6, 2024
pythongh-122728: Fix typo in PyEval_GetLocals()
a3e88e4
pythongh-122728: Fix SystemError in PyEval_GetLocals()
1b9defc
pythongh-122728: Fix SystemError in PyEval_GetLocals()
c304680
vstinner
changed the title ~~[-]3.13.0rc1 regression in `gpgme`: `SystemError: Objects/dictobject.c:3774: bad argument to internal function`[/-]~~ [+]3.13.0rc1 regression in PyEval_GetLocals(): `SystemError: Objects/dictobject.c:3774: bad argument to internal function`[/+] on Aug 6, 2024
Eclips4
added
3.13only security fixesonly security fixes

3.14bugs and security fixesbugs and security fixes
on Aug 6, 2024
vstinner
added a commit that references this issue on Aug 6, 2024
gh-122728: Fix SystemError in PyEval_GetLocals() (#122735)
4767a6e
miss-islington
added a commit that references this issue on Aug 6, 2024
pythongh-122728: Fix SystemError in PyEval_GetLocals() (pythonGH-122735)
4b5380b
hroncok
added a commit that references this issue on Aug 6, 2024
00434: pythongh-122728: Fix SystemError in PyEval_GetLocals()
3e7c1bb
vstinner
added a commit that references this issue on Aug 6, 2024
[3.13] gh-122728: Fix SystemError in PyEval_GetLocals() (GH-122735) (#…
5c161cb
vstinner commented on Aug 6, 2024
vstinner
on Aug 6, 2024
Member
More actions
Fixed. Thanks @mgorny and @hroncok for the bug report.
vstinner
closed this as completed on Aug 6, 2024
brandtbucher
added a commit that references this issue on Aug 7, 2024
pythongh-122728: Fix SystemError in PyEval_GetLocals() (python#122735)
94cf6e7
blhsing
added a commit that references this issue on Aug 22, 2024
pythongh-122728: Fix SystemError in PyEval_GetLocals() (python#122735)
a68e530

Metadata

Assignees

No one assigned

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

3.13.0rc1 regression in PyEval_GetLocals(): SystemError: Objects/dictobject.c:3774: bad argument to internal function #122728

Description

Crash report

What happened?

CPython versions tested on:

Operating systems tested on:

Output from running 'python -VV' on the command line:

Linked PRs

Activity

thesamesam commented on Aug 6, 2024

hroncok commented on Aug 6, 2024

hroncok commented on Aug 6, 2024

vstinner commented on Aug 6, 2024

vstinner commented on Aug 6, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

3.13.0rc1 regression in PyEval_GetLocals(): `SystemError: Objects/dictobject.c:3774: bad argument to internal function` #122728