GeezerVison is showing github.com — Using functools.partial to make functions not considered as methods when given as enum values no longer works · Issue #125316 · python/cpython
Using functools.partial to make functions not considered as methods when given as enum values no longer works #125316DescriptionBug report
Bug description:
On python 3.10-3.12, the following snippet prints True, while on Python 3.13.0 it prints False:
from enum import Enum
from functools import partial
def a():
pass
def b():
pass
class MyCallables(Enum):
A = a
B = partial(b)
print(MyCallables.B in MyCallables)
This is because MyCallables.B is considered to be functools.partial(<function b at 0x756d7f0065c0>) on 3.13.0, when it used to be <MyCallables.B: functools.partial(<function b at 0x71f7cbc407c0>)> before.
This is something I've been using to allow function values in enums not to be considered methods, which I most likely got from this thread. In the example above, A would always be considered a method.
It seems like on 3.13.0, the "wrapper class" approach is the only one that works.
CPython versions tested on:
3.10, 3.11, 3.12, 3.13
Operating systems tested on:
Linux, Windows
Linked PRs
Activityericvsmith commented on Oct 11, 2024 ZeroIntensity commented on Oct 11, 2024 Confirmed on current main as well, technically a 3.13 regression. serhiy-storchaka commented on Oct 11, 2024 This is an intentional change, and it is documented. See #121027.
Using staticmethod() to set a callable attribute without making it a method is more common idiom. bluthej commented on Oct 11, 2024 @serhiy-storchaka maybe my title was not well formulated. This is what my issue boiled down to in my mind but I realize this is not exactly my problem, my problem is with the behavior I laid out in the snippet.
It used to be that we could use partial in order to use a function as the value for an enum variant while still having that variant act like one. With the breaking change you mentioned this is no longer possible, the enum variant is considered to be the function itself. But that's just a consequence (maybe even unintended, I don't know).
At least there is still the wrapper class approach that works! I guess I'll just update the stackoverflow thread I mentioned in case people run into that. bluthej commented on Oct 11, 2024 I should probably add that using staticmethod in that context doesn't do the trick. serhiy-storchaka commented on Oct 11, 2024 As was mentioned in other answer, there is a better solution -- use enum.member() (I did not know about it!). Reacted by Joffrey Bluthé bluthej commented on Oct 11, 2024 Thanks for the tip! I had seen that answer but since it wasn't upvoted much I didn't try 😅 serhiy-storchaka commented on Oct 12, 2024 #125361 should fix this for 3.13. It restores the old behavior of partial in enums and adds a runtime warning. In 3.14 the behavior will be changed in any case.
We tried to emit a warning about future behavior change, but adding a warning already changed the behavior in some cases. Reacted by Joffrey Bluthé ZeroIntensity commented on Oct 14, 2024 @hacscred This kind of feedback isn't helpful--we don't intentionally break code, this is a regression. Please read PEP-387 for our backwards compatibility policy. Reacted by Jacob Coffee and Eric V. Smith MegaIng commented on Oct 25, 2024
This kind of feedback isn't helpful--we don't intentionally break code, this is a regression. Please read PEP-387 for our backwards compatibility policy.
No, this is clearly wrong. #121089 was an intentional break in backwards compatibility, disregarding PEP-387 with the argument that "this will only rarely break code". ZeroIntensity commented on Oct 25, 2024 Yes, but this specific case with Enum was a regression and was fixed for this case. If that PR is causing more problems, open a new issue.
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|