Description

julienp

opened on Oct 13, 2024

Issue body actions

Bug report

Bug description:

When using the virtualenv activate script in Git Bash for Windows, the environment is not correctly detected and paths are not converted.

This results in $PATH being set to something like D:\a\github-actions-shells\github-actions-shells\venv/Scripts:..., instead of /d/a/github-actions-shells/github-actions-shells/venv/Scripts.

Prior to #112508, the detection used $OSTYPE, which reports msys in Git Bash for Windows, however uname returns MINGW....

This is a regression in Python 3.13.0

CPython versions tested on:

3.13

Operating systems tested on:

Windows

Linked PRs

• gh-125398: Convert paths in venv activate script when using Git Bash under Windows #125399
• [3.13] gh-125398: Convert paths in venv activate script when using Git Bash under Windows (GH-125399) #125733

Reacted by Y5

Activity

1. julienp

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Oct 13, 2024
2. picnixz

   added

   topic-venvRelated to the venv moduleRelated to the venv module

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on Oct 13, 2024
3. github-merge-queue

   added a commit that references this issue on Oct 14, 2024

   Support Python 3.13 (#17520)

   6e9ec22
4. vsajip

   added a commit that references this issue on Oct 19, 2024

   gh-125398: Convert paths in venv activate script when using Git Bash …

   2a378db
5. vsajip

   closed this as completedin #125399on Oct 19, 2024
6. miss-islington

   added a commit that references this issue on Oct 19, 2024

   pythongh-125398: Convert paths in venv activate script when using Git…

   66bda75
7. vsajip

   added a commit that references this issue on Oct 19, 2024

   [3.13] gh-125398: Convert paths in venv activate script when using Gi…

   9e43330
8. y5c4l3 commented on Oct 21, 2024

   

   y5c4l3

   on Oct 21, 2024

   Contributor

   More actions

   uname -o seems a more semantic and stable candidate for MSYS2 detection, as well as Cygwin. Since it's merged already, I'll leave the outputs here only for reference.

   
   
9. ebonnal

   added a commit that references this issue on Jan 12, 2025

   pythongh-125398: Convert paths in venv activate script when using Git…

   f781a5d

Issue actions