Description

tungol

opened on Nov 5, 2024

Issue body actions

Feature or enhancement

Proposal:

For consistency with the types that they proxy, I believe that multiprocessing.managers.ListProxy should be registered to collections.abc.MutableSequence and multiprocessing.managers.DictProxy should be registered to collections.abc.MutableMapping. This could be done by registering either those types themselves or by registering their base classes, BaseListProxy and _BaseDictProxy.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

I discovered that these weren't registered to their ABCs while working on typeshed, so a little previous discussion occurred in issues in that repo:

python/typeshed#12893

python/typeshed#12892

Linked PRs

• gh-126417: Register multiprocessing proxy types to an appropriate collections.abc class #126419
• [3.13] gh-126417: Register multiprocessing proxy types to an appropriate collections.abc class (#126419) #126435
• [3.12] gh-126417: Register multiprocessing proxy types to an appropriate collections.abc class (#126419) #126436
• gh-126417: validate ABC methods on multiprocessing proxy types #126454
• [3.13] gh-126417: validate ABC methods on multiprocessing proxy types (GH-126454) #126674
• [3.12] gh-126417: validate ABC methods on multiprocessing proxy types (GH-126454) #126675

Activity

1. tungol

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on Nov 5, 2024
2. ZeroIntensity

   added

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on Nov 5, 2024
3. kumaraditya303

   added a commit that references this issue on Nov 5, 2024

   gh-126417: Register multiprocessing proxy types to an appropriate col…

   78842e4
4. AlexWaygood

   added 4 commits that reference this issue on Nov 5, 2024

   [3.13] pythongh-126417: Register multiprocessing proxy types to an ap…

   1a6c61a

   [3.12] pythongh-126417: Register multiprocessing proxy types to an ap…

   1b557b0

   [3.12] gh-126417: Register multiprocessing proxy types to an appropri…

   47d48b6

   [3.13] gh-126417: Register multiprocessing proxy types to an appropri…

   c1e708a
5. AlexWaygood commented on Nov 5, 2024

   

   AlexWaygood

   on Nov 5, 2024

   Member

   More actions

   Thanks @tungol!
6. AlexWaygood

   closed this as completedon Nov 5, 2024
7. gpshead

   added a commit that references this issue on Nov 11, 2024

   gh-126417: validate ABC methods on multiprocessing proxy types (#126454)

   6ee542d
8. miss-islington

   added 2 commits that reference this issue on Nov 11, 2024

   pythongh-126417: validate ABC methods on multiprocessing proxy types (p…

   4b77c99

   pythongh-126417: validate ABC methods on multiprocessing proxy types (p…

   7944ead
9. gpshead commented on Nov 11, 2024

   

   gpshead

   on Nov 11, 2024

   Member

   More actions

   FYI - The backports of the validation test don't work on 3.13 or earlier because ListProxy in those versions does not have the methods added to 3.14 by #103133.

   I'll close those backports.
10. AlexWaygood

    added 2 commits that reference this issue on Nov 12, 2024

    Revert "[3.13] pythongh-126417: Register multiprocessing proxy types …

    bf7cb54

    Revert "[3.12] pythongh-126417: Register multiprocessing proxy types …

    6514a09
11. AlexWaygood commented on Nov 12, 2024

    

    AlexWaygood

    on Nov 12, 2024

    Member

    More actions

    The backports of the original PR are being reverted in:

    • [3.13] gh-126451: Revert backports of ABC registrations for contextvars.Context and multiprocessing proxies #126734
    • [3.12] gh-126451: Revert backports of ABC registrations for contextvars.Context and multiprocessing proxies #126735

    (We're not reverting it for 3.14+, it's a good change! But there were concerns raised in #126451 over whether it was a good idea to backport this kind of change, and I think those concerns were reasonable.)

    Reacted by Gregory P. Smith
12. picnixz

    added 2 commits that reference this issue on Dec 8, 2024

    pythongh-126417: Register multiprocessing proxy types to an appropria…

    ed57168

    pythongh-126417: validate ABC methods on multiprocessing proxy types (p…

    1f7f18b
13. ebonnal

    added 2 commits that reference this issue on Jan 12, 2025

    pythongh-126417: Register multiprocessing proxy types to an appropria…

    ae487ce

    pythongh-126417: validate ABC methods on multiprocessing proxy types (p…

    7199e76

Issue actions