Description

vstinner

opened on Jan 27, 2025

Issue body actions

Feature or enhancement

Proposal:

The existing PySys_GetObject() function has two issues:

• It returns a borrowed reference.
• It ignores errors.

I propose adding new functions PySys_GetAttr() and PySys_GetAttrString() to get a sys module attribute which return a strong reference and don't ignore errors.

API:

PyObject *PySys_GetAttr(PyObject *name)
PyObject *PySys_GetAttrString(const char *name)

• Return a new object (strong reference) on success.

• Set an exception and return NULL on error:

  • Set an AttributeError if the attribute doesn't exist.
  • Set a RuntimeError if the sys module cannot be retrieved.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

• gh-129367: Add PySys_GetAttr() function #129369

Activity

1. vstinner

   added

   topic-C-API

   type-featureA feature request or enhancementA feature request or enhancement

   on Jan 27, 2025
2. vstinner

   added a commit that references this issue on Jan 27, 2025

   pythongh-129367: Add PySys_GetAttr() function

   d62380a
3. vstinner commented on Jan 27, 2025

   

   vstinner

   on Jan 27, 2025

   MemberAuthor

   More actions

   An alternative would be to accept an object and add a String function for the const char* argument:

   PyObject *PySys_GetAttr(PyObject *name)
   PyObject *PySys_GetAttrString(const char *name)
   

   I'm not sure if it's worth it to have an alternative with PyObject*.

   UPDATE: I added PySys_GetAttrString(). @serhiy-storchaka conducted a code analysis in 2023 and found that we need a function which takes a PyObject* name.

   By the way, I'm also proposing to add PyImport_ImportModuleAttrString(mod_name, attr_name) which is similar: PyImport_ImportModuleAttrString("sys", "path") can be used to get sys.path for example. See issue #128911.

   IMO it's still relevant to add PySys_GetAttrString(name) even if PyImport_ImportModuleAttrString(mod_name, attr_name) is added: PySys_GetAttrString(name) is faster, it doesn't have to go into the importlib machinery.
4. vstinner commented on Jan 27, 2025

   

   vstinner

   on Jan 27, 2025

   MemberAuthor

   More actions

   See also #108512 "C API: Add a replacement for PySys_GetObject".
5. serhiy-storchaka commented on Jan 28, 2025

   

   serhiy-storchaka

   on Jan 28, 2025

   Member

   More actions

   Isn't it a duplicate of #108512? That issue turned out to be more complex, because we have at least 4 different functions that implements this with different particularities.
6. vstinner commented on Jan 28, 2025

   

   vstinner

   on Jan 28, 2025

   MemberAuthor

   More actions

   Isn't it a duplicate of #108512?

   Right. I close my issue.
7. vstinner

   closed this as a duplicateof C API: Add a replacement for PySys_GetObject #108512 on Jan 28, 2025

Issue actions