GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Do not build the freeze module twice in case of Windows PGO builds · Issue #130419 · python/cpython

Do not build the freeze module twice in case of Windows PGO builds #130419

New issue
Copy link
New issue
Copy link
Closed
Closed
Do not build the freeze module twice in case of Windows PGO builds#130419
Copy link
Labels
OS-windowsbuildThe build process and cross-buildThe build process and cross-buildtype-featureA feature request or enhancementA feature request or enhancement

Description

@chris-eibl
chris-eibl
opened on Feb 21, 2025
Issue body actions

Feature or enhancement

Proposal:

From #129907 (comment)

Avoiding the rebuild of _freeze_module and the refreezing would be nice, but it's not a huge deal (a few seconds in a ~hour long release process). Don't mix it in with this PR.

This is another low hanging fruit to make the Windows PGO build slightly faster (like #90281 did) by not building the _freeze_module again in the PGUpdate phase.

This will decrease both the MSVC and the clang-cl PGO build time (#130090).

In case of clang-cl, this saves me up to 40 seconds on my machine. Please see #131005 Details pgupdate build times for more numbers

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

  • gh-130419: Do not build the _freeze_module twice in case of Windows PGO builds #130420

Activity

  1. chris-eibl
    added
    type-featureA feature request or enhancementA feature request or enhancement
    on Feb 21, 2025
  2. picnixz
    added
    OS-windows
    buildThe build process and cross-buildThe build process and cross-build
    on Feb 21, 2025
  3. zooba
    added a commit that references this issue on Feb 24, 2025

    gh-130419: Do not build the _freeze_module project twice in Windows P…

    3a555f0
  4. zooba
    closed this as completedon Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-windowsbuildThe build process and cross-buildThe build process and cross-buildtype-featureA feature request or enhancementA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.