Description

r4ph43l-glitch

opened on Feb 28, 2025

Issue body actions

Bug report

Bug description:

# current tkinter/__init__.py

class Text(...):
[...]
    def search(self, pattern, index, stopindex=None,
           forwards=None, backwards=None, exact=None,
           regexp=None, nocase=None, count=None, elide=None):
[...]

The current tkinter implementation of the tkinter.Text.search method misses use of tcl options:
-nolinestop
-all
-overlap
-strictlimits

Is there any reason on why it is not inside the CPython implementation?

CPython versions tested on:

3.13

Operating systems tested on:

Windows

Linked PRs

• gh-130693: Add options of the tkinter.Text.search method: -nolinestop -all -overlap -strictlimits #130848
• [3.14] gh-130693: Add more tests for tkinter.Text.search() (GH-130848) #141669
• [3.13] gh-130693: Add more tests for tkinter.Text.search() (GH-130848) (GH-141669) #141670

Activity

1. r4ph43l-glitch

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Feb 28, 2025
2. picnixz

   added

   type-featureA feature request or enhancementA feature request or enhancement

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   topic-tkinter

   and removed

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Feb 28, 2025
3. sharktide commented on Mar 4, 2025

   

   sharktide

   on Mar 4, 2025

   Contributor

   More actions

   I'll see if I can make a pr
4. sharktide commented on Mar 4, 2025

   

   sharktide

   on Mar 4, 2025

   Contributor

   More actions

   Almost done, I have to write unittests.
5. sharktide commented on Mar 4, 2025

   

   sharktide

   on Mar 4, 2025

   Contributor

   More actions

   is currently avalible at https://github.com/sharktide/cpython/tree/patch-130693
6. sharktide

   added a commit that references this issue on May 5, 2025

   pythongh-130693 Remove wordiness; only title left

   6ce83e3
7. sharktide commented on May 30, 2025

   

   sharktide

   on May 30, 2025

   Contributor

   More actions

   I am currently pinging this issue as I have not seen a review for nearly a month. Could someone please review soon?

   PR: gh-130848
8. serhiy-storchaka commented on Aug 10, 2025

   

   serhiy-storchaka

   on Aug 10, 2025

   Member

   More actions

   For -all, it would be more Pythonic to add a separate method search_all() which returns a list or a tuple.
9. sharktide commented on Aug 10, 2025

   

   sharktide

   on Aug 10, 2025

   Contributor

   More actions

   For -all, it would be more Pythonic to add a separate method search_all() which returns a list or a tuple.

   on it
10. serhiy-storchaka

    added a commit that references this issue on Nov 17, 2025

    gh-130693: Support more options for search in tkinter.Text (GH-130848)

    3d14805
11. serhiy-storchaka

    closed this as completedin #130848on Nov 17, 2025
12. serhiy-storchaka

    added 2 commits that reference this issue on Nov 17, 2025

    pythongh-130693: Add more tests for tkinter.Text.search() (pythonGH-1…

    93cdf3f

    [3.14] gh-130693: Add more tests for tkinter.Text.search() (GH-130848) (

    8db1aad
13. miss-islington

    added a commit that references this issue on Nov 17, 2025

    [3.14] pythongh-130693: Add more tests for tkinter.Text.search() (pyt…

    90a86c4
14. serhiy-storchaka

    added a commit that references this issue on Nov 17, 2025

    [3.13] gh-130693: Add more tests for tkinter.Text.search() (GH-130848) (

    0280744
15. StanFromIreland

    added a commit that references this issue on Dec 6, 2025

    pythongh-130693: Support more options for search in tkinter.Text (pyt…

    6467f73

Issue actions