GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133623: Add ssl.HAS_PSK_TLS13 to detect external TLS 1.3 PSK support by WillChilds-Klein · Pull Request #133624 · python/cpython

Conversation

@WillChilds-Klein

@WillChilds-Klein WillChilds-Klein commented May 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Notes

Please see #133623's description for broader discussion of the feature.

AWS-LC now sets an OPENSSL_NO_EXTERNAL_PSK_TLS13 macro that this PR uses to detect external TLS 1.3 PSK support.

This PR is largely based on PR #128036's patterns. If the edit to Doc/whatsnew/3.15.rst is unnecessary, I'm happy to remove it.

Testing

  • CPython CI
  • AWS-LC recently adjusted our CPython CI patch file, conforming to this PR's contents

  • Issue: Add ssl.HAS_PSK_TLS13 to detect libssl external TLS 1.3 PSK support #133623

📚 Documentation preview 📚: https://cpython-previews--133624.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@WillChilds-Klein
Add ssl.HAS_PSK_TLS13 to detect libssl external TLS 1.3 PSK support
5c9727c
@WillChilds-Klein
WillChilds-Klein requested review from gpshead and picnixz as code owners May 7, 2025 22:42
@bedevere-app bedevere-app Bot added the awaiting review label May 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 7, 2025
Add ssl.HAS_PSK_TLS13 to detect libssl external TLS 1.3 PSK support #133623
Closed
blurb-it Bot and others added 2 commits May 7, 2025 22:49
@blurb-it
📜🤖 Added by blurb_it.
1521abb
@WillChilds-Klein
Update whatsnew entry with PR ID
dd5ad5d
picnixz
picnixz approved these changes May 7, 2025
View reviewed changes
Comment thread Doc/library/ssl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 7, 2025
WillChilds-Klein and others added 2 commits May 7, 2025 19:00
@WillChilds-Klein @picnixz
Update Doc/library/ssl.rst
6fc7e2b
Co-authored-by: Bénédikt Tran <[email protected]>
@WillChilds-Klein @picnixz
Update Doc/whatsnew/3.15.rst
bfc64ff
Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz picnixz self-assigned this May 7, 2025
@WillChilds-Klein
Remove whatsnew change, not ready for 3.15 yet
bf53321
picnixz
picnixz reviewed May 8, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

WillChilds-Klein added 3 commits May 8, 2025 15:08
@WillChilds-Klein
Revert "Remove whatsnew change, not ready for 3.15 yet"
9a1128e
This reverts commit bf53321.
@WillChilds-Klein
Add extra newline to match 3.14 whatsnews formatting
459baa9
@WillChilds-Klein
Merge branch 'main' into has-psk-tls13
f8493b8
@picnixz
picnixz merged commit 6801bd3 into python:main May 9, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2025
@WillChilds-Klein
WillChilds-Klein deleted the has-psk-tls13 branch May 9, 2025 14:13
@WillChilds-Klein WillChilds-Klein mentioned this pull request May 9, 2025
Remove python CI patch for main aws/aws-lc#2407
Merged
WillChilds-Klein added a commit to aws/aws-lc that referenced this pull request May 9, 2025
@WillChilds-Klein
Remove python CI patch for main (#2407)
cd061a4
As of [PR 133624](python/cpython#133624),
CPython's mainline is now fully source- and test-compatible with AWS-LC.
This means that we can reduce our CI patch file to a static build
configuration.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@WillChilds-Klein @Pranjal095
pythongh-133623: Add ssl.HAS_PSK_TLS13 to detect external TLS 1.3 P…
e4b6329
…SK support (python#133624)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@WillChilds-Klein @taegyunkim
pythongh-133623: Add ssl.HAS_PSK_TLS13 to detect external TLS 1.3 P…
6930418
…SK support (python#133624)
This was referenced May 8, 2026
Python 3.15: sort allowlists, more small updates python/typeshed#15714
Merged
Add Python 3.15 socket SSL and platform updates python/typeshed#15734
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@picnixz picnixz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@WillChilds-Klein @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.