GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Python 3.15: sort allowlists, more small updates by JelleZijlstra · Pull Request #15714 · python/typeshed

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Part of #15709.

I pointed Codex at the What's New for 3.15 and told it to apply every change relevant to typeshed, then told it to get stubtest running on 3.15 (which found python/cpython#149504) and fix the remaining issues. I also reviewed manually and made a few adjustments (including noticing python/cpython#149534).

Most of the changes were split into smaller PRs; this one now is allowlist sorting plus a few smaller things that were missed. There's a few more allowlist entries that look fixable, but I'll save that for later PRs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
JelleZijlstra added 12 commits May 7, 2026 10:41
@JelleZijlstra
Update stdlib stubs for Python 3.15
c28a77a
@JelleZijlstra
Fix Python 3.15 stubtest coverage
d38cf68
@JelleZijlstra
Expand Python 3.15 stdlib coverage
de50b34
@JelleZijlstra
Fix Python 3.15 stub review issues
938b345
@JelleZijlstra
fixes
7d58087
@JelleZijlstra
more fixes
00892f3
@JelleZijlstra
fix more
39788e6
@JelleZijlstra
not you
cec3aca
@JelleZijlstra
no stubtest for now
3a20644
@JelleZijlstra
no commit
16fbcb9
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into python315
12371f1
# Conflicts:
#	stdlib/_interpqueues.pyi
#	stdlib/ast.pyi
#	stdlib/base64.pyi
#	stdlib/collections/__init__.pyi
#	stdlib/glob.pyi
#	stdlib/importlib/metadata/__init__.pyi
#	stdlib/pyexpat/__init__.pyi
#	stdlib/sys/__init__.pyi
#	stdlib/threading.pyi
#	stdlib/types.pyi
#	stdlib/typing.pyi
#	stdlib/unicodedata.pyi
#	stdlib/unittest/_log.pyi
#	stdlib/unittest/case.pyi
#	stdlib/wave.pyi
#	stdlib/zipimport.pyi
@JelleZijlstra
stubtest
0db9084
@github-actions

This comment has been minimized.

Sign in to view
@srittau

srittau commented May 8, 2026

Copy link
Copy Markdown
Collaborator

I would like to get the testing infrastructure for 3.15 up before adding 3.15 branches. It also doesn't fill me with confidence that we already have stubtest errors without even testing 3.15.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@srittau

srittau commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Here's my suggestion on how to move forward:

  1. Get the testing infrastructure in place. We'll need to add many stubtest allow entries as a "to do list" to the 3.15 allow lists. (Like we had in the past.)
  2. Split this PR into multiple PRs with a size that's easily reviewable.
  3. Fix remaining issues per PR, but move "harder" fixes to separate PRs if necessary.
  4. Review each PR manually for plausibility and style. When looking at the existing PR, it's clear to me that on the one hand the LLM managed to do a lot of the "grunt work" and provide a good baseline, but on the other hand delivered results that are not suitable for unsupervised inclusion in typeshed.
sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn
sobolevn reviewed May 8, 2026
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this work! I agree with @srittau that it is rather hard to review 1600+ lines of changes accross different modules :(

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread stdlib/collections/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread stdlib/sys/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mbyrnepr2

mbyrnepr2 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Hi! There's one new addition in 3.15 which I notice is missing from the release notes and the current PR:
python/cpython#140951
https://docs.python.org/3.15/library/wave.html#wave.open.

I guess if the What's New is up to date there shouldn't be a problem for the AI but maybe there are other changes also missing?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra

JelleZijlstra commented May 8, 2026

Copy link
Copy Markdown
Member Author

wave.open: Yes, I had it look only at the What's New. I think we're liable to miss such changes to only allowed parameter types, because there's no automatic way to check them; I wouldn't be surprised if we similarly missed some changes for earlier versions. Maybe I'll try making an AI look at the whole diff between 3.14 and 3.15 and flag things that were missed.

Point taken on getting CI set up first, I'll do that.

The stubtest failures seem to be mostly from changes that were made unconditionally that should have been made conditional on version.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
Add Python 3.15 test infrastructure
44d2e56
@JelleZijlstra
JelleZijlstra marked this pull request as draft May 8, 2026 16:11
@JelleZijlstra
Merge branch 'codex/python315-testing' into python315
b594b7e
@JelleZijlstra

JelleZijlstra commented May 8, 2026

Copy link
Copy Markdown
Member Author

My plan now:

  • Add 3.15 CI (Add Python 3.15 test infrastructure #15718)
  • Make Codex fix all CI issues on this PR to have a clean slate (in progress)
  • Extract separate PRs for smaller changes (probably <5 modules at a time); start them as draft and request review when I feel they're ready.
srittau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@srittau

srittau commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Extract separate PRs for smaller changes (probably <5 modules at a time); start them as draft and request review when I feel they're ready.

I'll try to prioritize reviewing. If it's just small, straight-forward changes, I'm fine with larger PRs. It's more about the amount if lines and the complexity than the amount of modules.

JelleZijlstra reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra and others added 4 commits May 8, 2026 09:36
@JelleZijlstra
Fix Python 3.15 stubtest guards
8fdc247
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1140f0b
@JelleZijlstra
Fix older stdlib stubtest after 3.15 updates
f5589f6
@JelleZijlstra
Merge remote-tracking branch 'origin/python315' into python315
7720c6a
JelleZijlstra
JelleZijlstra commented May 8, 2026
View reviewed changes
Comment thread stdlib/profiling/sampling.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra added 2 commits May 8, 2026 09:45
@JelleZijlstra
Allow platform-dependent hashlib exports
4e7b6d7
@JelleZijlstra
Fix platform 3.15 stubtest allowlists
a278ef4
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into python315
c3d6741
# Conflicts:
#	stdlib/@tests/stubtest_allowlists/darwin-py315.txt
#	stdlib/@tests/stubtest_allowlists/linux-py315.txt
#	stdlib/@tests/stubtest_allowlists/py315.txt
#	stdlib/@tests/stubtest_allowlists/win32-py315.txt
#	stdlib/_collections_abc.pyi
#	stdlib/_socket.pyi
#	stdlib/_ssl.pyi
#	stdlib/binascii.pyi
#	stdlib/builtins.pyi
#	stdlib/calendar.pyi
#	stdlib/collections/__init__.pyi
#	stdlib/datetime.pyi
#	stdlib/difflib.pyi
#	stdlib/hashlib.pyi
#	stdlib/mmap.pyi
#	stdlib/platform.pyi
#	stdlib/re.pyi
#	stdlib/resource.pyi
#	stdlib/socket.pyi
#	stdlib/sqlite3/__init__.pyi
#	stdlib/typing.pyi
#	stdlib/unittest/_log.pyi
#	stdlib/wave.pyi
JelleZijlstra
JelleZijlstra commented May 9, 2026
View reviewed changes
Comment thread stdlib/collections/__init__.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra added 6 commits May 9, 2026 11:29
@JelleZijlstra
Fix Python 3.15 CI after merge
689f19b
@JelleZijlstra
Complete profiling collector methods
d8dda00
@JelleZijlstra
Remove covered profiling allowlist entries
49c1fd6
@JelleZijlstra
Fix base profiling export parameter
f4770a2
@JelleZijlstra
Allowlist profiling sampling internals
6ec21e1
@JelleZijlstra
Fix remaining Python 3.15 stubtest failures
10bb878
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra JelleZijlstra mentioned this pull request May 9, 2026
Add more Python 3.15 stdlib updates #15747
Merged
@JelleZijlstra
Merge upstream/main into python315
cc2f7d5
@github-actions

This comment has been minimized.

Sign in to view
JelleZijlstra added 2 commits May 11, 2026 09:00
@JelleZijlstra
Organize Python 3.15 stubtest allowlists
ba00d28
@JelleZijlstra
Guard NODEV on Python 3.15
6df830a
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into python315
e5d6c98
# Conflicts:
#	stdlib/@tests/stubtest_allowlists/py315.txt
@github-actions

This comment has been minimized.

Sign in to view
JelleZijlstra added 2 commits May 12, 2026 20:09
@JelleZijlstra
Tighten Python 3.15 allowlist entries
3bd8325
@JelleZijlstra
Guard ctypes complex type codes
e3a4134
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra JelleZijlstra changed the title Update stdlib for Python 3.15 Python 3.15: sort allowlists, more small updates May 13, 2026
@JelleZijlstra
Merge branch 'main' into python315
4e42234
@JelleZijlstra

JelleZijlstra commented May 13, 2026

Copy link
Copy Markdown
Member Author

With lots of other PRs merged, this is now mostly allowlist sorting.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
JelleZijlstra marked this pull request as ready for review May 13, 2026 03:32
@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

srittau
srittau approved these changes May 13, 2026
View reviewed changes
@srittau
srittau merged commit 4076e24 into python:main May 13, 2026
58 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
JelleZijlstra deleted the python315 branch May 13, 2026 13:00
@mbyrnepr2 mbyrnepr2 mentioned this pull request May 22, 2026
Add type stubs for the wave stdlib module to align with the Python 3.15 beta changes. #15824
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments
@srittau srittau srittau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @srittau @mbyrnepr2 @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.