GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — Python 3.15: sort allowlists, more small updates by JelleZijlstra · Pull Request #15714 · python/typeshed Conversation
|
|
I would like to get the testing infrastructure for 3.15 up before adding 3.15 branches. It also doesn't fill me with confidence that we already have stubtest errors without even testing 3.15. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Here's my suggestion on how to move forward:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this work! I agree with @srittau that it is rather hard to review 1600+ lines of changes accross different modules :(
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Hi! There's one new addition in 3.15 which I notice is missing from the release notes and the current PR: I guess if the What's New is up to date there shouldn't be a problem for the AI but maybe there are other changes also missing? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
wave.open: Yes, I had it look only at the What's New. I think we're liable to miss such changes to only allowed parameter types, because there's no automatic way to check them; I wouldn't be surprised if we similarly missed some changes for earlier versions. Maybe I'll try making an AI look at the whole diff between 3.14 and 3.15 and flag things that were missed. Point taken on getting CI set up first, I'll do that. The stubtest failures seem to be mostly from changes that were made unconditionally that should have been made conditional on version. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
My plan now:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I'll try to prioritize reviewing. If it's just small, straight-forward changes, I'm fine with larger PRs. It's more about the amount if lines and the complexity than the amount of modules. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
# Conflicts: # stdlib/@tests/stubtest_allowlists/darwin-py315.txt # stdlib/@tests/stubtest_allowlists/linux-py315.txt # stdlib/@tests/stubtest_allowlists/py315.txt # stdlib/@tests/stubtest_allowlists/win32-py315.txt # stdlib/_collections_abc.pyi # stdlib/_socket.pyi # stdlib/_ssl.pyi # stdlib/binascii.pyi # stdlib/builtins.pyi # stdlib/calendar.pyi # stdlib/collections/__init__.pyi # stdlib/datetime.pyi # stdlib/difflib.pyi # stdlib/hashlib.pyi # stdlib/mmap.pyi # stdlib/platform.pyi # stdlib/re.pyi # stdlib/resource.pyi # stdlib/socket.pyi # stdlib/sqlite3/__init__.pyi # stdlib/typing.pyi # stdlib/unittest/_log.pyi # stdlib/wave.pyi
There was an error while loading. Please reload this page.
# Conflicts: # stdlib/@tests/stubtest_allowlists/py315.txt
|
With lots of other PRs merged, this is now mostly allowlist sorting. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.