GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Eliminate duplication of the check for the MS_WINDOWS macro. · Issue #138206 · python/cpython

Eliminate duplication of the check for the MS_WINDOWS macro. #138206

New issue
Copy link
New issue
Copy link
Open
Open
Eliminate duplication of the check for the MS_WINDOWS macro.#138206
Copy link
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)

Description

@nybblista
nybblista
opened on Aug 27, 2025
Issue body actions

I think there is no need to check for MS_WINDOWS macro twice here.

cpython/Python/pythonrun.c

Lines 34 to 43 in bbcb75c

#ifdef MS_WINDOWS
# include "malloc.h" // alloca()
#endif
#ifdef MS_WINDOWS
# undef BYTE
# include "windows.h"
#endif

Linked PRs

  • gh-138206: Eliminate duplication of the check for the MS_WINDOWS macro. #138207

Activity

  1. StanFromIreland
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)
    type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)
    on Aug 27, 2025

  2. nybblista commented on Dec 11, 2025

    @nybblista
    nybblista
    on Dec 11, 2025
    ContributorAuthor
    More actions

    @iritkatriel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.