GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-138206: Eliminate duplication of the check for the MS_WINDOWS macro. by nybblista · Pull Request #138207 · python/cpython

Conversation

@nybblista

@nybblista nybblista commented Aug 27, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Duplication of the check for the MS_WINDOWS macro is eliminated.

  • Issue: Eliminate duplication of the check for the MS_WINDOWS macro. #138206

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nybblista
eliminate duplication of the check for the MS_WINDOWS macro.
f3cc252
@nybblista
nybblista requested a review from ericsnowcurrently as a code owner August 27, 2025 19:41
@bedevere-app bedevere-app Bot added the awaiting review label Aug 27, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 27, 2025
Eliminate duplication of the check for the MS_WINDOWS macro. #138206
Open
@StanFromIreland StanFromIreland added skip news type-refactor Code refactoring (with no changes in behavior) labels Aug 27, 2025
@nybblista

nybblista commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

@ericsnowcurrently @StanFromIreland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news stale Stale PR or inactive for long period of time. type-refactor Code refactoring (with no changes in behavior)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nybblista @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.