GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve usage of `_setSSLError` in `_ssl.c` · Issue #138634 · python/cpython

Improve usage of _setSSLError in _ssl.c #138634

New issue
Copy link
New issue
Copy link
Open
Open
Improve usage of _setSSLError in _ssl.c#138634
Copy link
Assignees
picnixz
Labels
extension-modulesC modules in the Modules dirC modules in the Modules dirsprinttopic-SSLtype-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)

Description

@picnixz
picnixz
opened on Sep 8, 2025
Issue body actions

Proposal:

Based on #137198 (comment), we should refactor _setSSLError as the errcode argument is redundant. In addition, we should:

  • Change _ssl__SSLContext_set_ciphers_impl to use _setSSLError as in _ssl__SSLContext_set_ciphersuites_impl.
  • If possible, ease the use of _setSSLError.
  • If possible, ease how we indicate that a functionality is not implemented and document which exception is being actually raised (this needs to be synchronized with Improve documentation of SSL module #138633).

Has this already been discussed elsewhere?

I have already discussed this feature proposal.

Links to previous discussion of this feature:

  • gh-138252: Add support in SSL module for getting and setting TLS signature algorithms #138269 (comment)
  • gh-138252: Add support in SSL module for getting and setting TLS signature algorithms #138269 (comment)
  • gh-137197: Add SSLContext.set_ciphersuites to set TLS 1.3 ciphers #137198 (comment)

Note

I will take care of this myself.

Reacted by yihong

Activity

  1. picnixz
    self-assigned this
    on Sep 8, 2025
  2. picnixz
    added
    extension-modulesC modules in the Modules dirC modules in the Modules dir
    topic-SSL
    type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)
    sprint
    on Sep 8, 2025
  3. github-project-automation
    added this to Sprinton Sep 14, 2025
  4. github-project-automation
    moved this to Todo in Sprinton Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @picnixz
    picnixz

Labels

extension-modulesC modules in the Modules dirC modules in the Modules dirsprinttopic-SSLtype-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)

Projects

  • Sprint
    Status
    Todo
    Show more project fields

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.