Description

KowalskiThomas

opened on Mar 3, 2026

Issue body actions

I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?)

In the StackTraceCollector, it seems like self.skip_idle is set but never used, as every collect method gets another skip_idle parameter that they use in _iter_stacks (or their calls to parent class' methods).

Based on the code for e.g. live_collector, it seems like the pattern is to use the attribute, not a parameter.

Linked PRs

• gh-145458: use self.skip_idle #145459

Activity

1. KowalskiThomas

   added a commit that references this issue on Mar 3, 2026

   pythongh-145458: use self.skip_idle

   7d031a1
2. picnixz

   added

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   3.15bugs and security fixesbugs and security fixes

   topic-profiling

   on Mar 3, 2026
3. picnixz commented on Mar 3, 2026

   

   picnixz

   on Mar 3, 2026

   Member

   More actions

   I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?)

   When you are not sure about something, please avoid create draft PRs and wait for a maintainer to acknowledge the issue. You can say that you have a PR ready in case this is acknowledge but please avoid opening PRs that are not sure to be merged.

   Reacted by Thomas Kowalski
4. KowalskiThomas commented on Mar 3, 2026

   

   KowalskiThomas

   on Mar 3, 2026

   ContributorAuthor

   More actions

   Sounds good, noted. Sorry about this. I'll avoid doing this in the future.
5. encukou commented on Mar 10, 2026

   

   encukou

   on Mar 10, 2026

   Member

   More actions

   cc @pablogsal
6. pablogsal

   added a commit that references this issue on Mar 31, 2026

   gh-145458: use `self.skip_idle` consistently in the tachyon profiler (#…

   b4fac15
7. maurycy

   added a commit that references this issue on Mar 31, 2026

   Merge branch 'main' into tachyon-ndjson-kolektor

   9836ffa
8. KowalskiThomas commented on Apr 8, 2026

   

   KowalskiThomas

   on Apr 8, 2026

   ContributorAuthor

   More actions

   I think we can close this, right? Now that #145459 is merged.

   Reacted by Bénédikt Tran
9. picnixz

   closed this as completedon Apr 8, 2026
10. clin1234

    added a commit that references this issue on Apr 16, 2026

    pythongh-145458: use `self.skip_idle` consistently in the tachyon pro…

    b911816
11. ljfp

    added a commit that references this issue on Apr 25, 2026

    pythongh-145458: use `self.skip_idle` consistently in the tachyon pro…

    12bd087

Issue actions