GeezerVison is showing github.com — Fix various bugs in compiler pipeline from bug report · Issue #146442 · python/cpython
Fix various bugs in compiler pipeline from bug report #146442Labels interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error DescriptionBug report
Bug description:
This is a sub-issue of #146102, details copied from gist:
Compiler Pipeline (codegen + compile + symtable + flowgraph + assemble) | 6 FIX
codegen.c (6,632 lines) — 4 FIX
- NULL deref + ref leak in
codegen_setup_annotations_scope (line 716-720): PyLong_FromLong result not NULL-checked, passed to ADDOP_LOAD_CONST which dereferences it. Also never DECREF'd even on success.
- Ref leak of
mangled in codegen_nameop (line 3280): RETURN_IF_ERROR(scope) early-returns without DECREF'ing mangled from _PyCompile_MaybeMangle.
- : 7 macro sites between allocation and consumption can early-return, leaking
mangled.
- Unchecked
_PyCompile_PushFBlock in codegen_unwind_fblock_stack (line 669): Return value silently discarded, error lost, frame block stack left inconsistent.
compile.c (1,772 lines) — 1 FIX
- Ref leak of
orig in _PyCompile_TweakInlinedComprehensionScopes (line 1096-1114): PyDict_GetItemRef returns new ref in orig, never DECREF'd on any path (success or error). Leaks on every inlined comprehension.
assemble.c (802 lines) — 1 FIX
assemble_emit_instr returns ERROR without exception (line 420-421): Bytecode overflow check returns ERROR without PyErr_NoMemory() → SystemError.
symtable.c (3,355 lines) — 0 FIX (clean)
flowgraph.c (4,088 lines) — 0 FIX (clean)
CPython versions tested on:
CPython main branch
Operating systems tested on:
Windows
Linked PRs
ActivityJelleZijlstra commented on Mar 26, 2026
NULL deref + ref leak in codegen_setup_annotations_scope (line 716-720): PyLong_FromLong result not NULL-checked, passed to ADDOP_LOAD_CONST which dereferences it. Also never DECREF'd even on success.
This called with a constant small integer, so we'll always get an interned and immortal object. For clarity still better to DECREF it, though. vstinner commented on Mar 27, 2026 Do you plan to write a PR to fix these issues? brianschubert commented on Mar 27, 2026 @vstinner they opened a PR against the parent issue. I just edited the PR to point to this issue instead Reacted by Victor Stinner A0su commented on Mar 30, 2026 ContributorAuthor More actions PR is merged, closing issue
MetadataMetadatainterpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error DevelopmentNo branches or pull requestsIssue actions
|