GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Cleanup: Possible removal of some `__wasi__` special case handling · Issue #156692 · python/cpython

Cleanup: Possible removal of some __wasi__ special case handling #156692

New issue
Copy link
New issue
Copy link
Open
Open
Cleanup: Possible removal of some __wasi__ special case handling#156692
Copy link
Labels
OS-wasiextension-modulesC modules in the Modules dirC modules in the Modules dirinterpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)

Description

@katharosada
katharosada
opened on Aug 31, 2026
Issue body actions

As a hopefully helpful cleanup task, I went through all the uses of __wasi__ special-casing in the CPython code and tried to figure out if any of them were not necessary anymore, mostly looking at the ones that might have been fixed by changes in wasi-libc.

I found a few, but the rest look like they are still needed. Happy to send PRs for the couple of ones at the top of the list which look like they can be safely removed.

The rest of the list is probably not useful, but I figured I would include it for completeness in case I have made some incorrect assumptions that stand out.

Full disclosure: I started off going through these one by one myself, but after the first pass to understand the patterns, I used Claude to scan and categorise the usages and to cross reference the wasi-libc changes where relevant. I did review the results carefully myself - especially spending time on the ones that looked like possible candidates for removal and doing my own searches for relevant issues/discussions. I've included some of the AI-generated summary, but I cut it down a lot and reworded it myself.

Good candidates for removal:

Modules/selectmodule.c:76 — define POLLPRI as no-op 0; missing from WASI SDK 16.

This is now defined in __header_poll.h as 0x0200 as of WASI SDK 33. It was added by wasi-libc PR #754 (merged); design discussion in issue #760 (open).

Modules/socketmodule.c:8428 — define the recv-truncated flag to work around wasi-libc issue #305, so MSG_TRUNC can be exported.

Looks like this was fixed by wasi-libc PR #391 (merged 2023-02-04); tracking issue #305 is still marked open but I think it could be closed now.

Possible candiates for removal:

linkat (posixmodule.c:4877) - This one needs further investigation or context it's not super clear to me why WASI was special-cased here.

Introduced by gh-81793 / PR #132517 (May 2025) which doesn't explicitly mention why the __wasi__ check was added. Possibly to preserve WASI's prior behaviour rather than risk changing the behavior, but it could be fine to remove. Removing it changes os.link's default symlink handling, so it could depend on what the WASi implementation does with that, I haven't tested removing this.

Could possibly be removed for preview2/3 when dropping support for preview1:

Parser/tokenizer/reader.c:718 — use a "borrowed fd" instead of dup().

wasi-libc implemented the dup-family for WASIp2/WASIp3 in PR #832 and PR #822, but the workaround must stay for preview1 (issue #459).

Probably need to be kept:

Modules/posixmodule.c:4157 — os.chmod becomes a no-op because WASI has no chmod or the underlying permission model.
wasi-libc added stubs in PR #463 that return ENOSYS, but CPython used these, it would cause a bunch of operations to error (same for relying on HAVE_CHMOD). The default of success is not great either (attempting to restrict permissions silently doesn't work), but it would need quite a bit of work to resolve all the cases where changing this would break something.

Modules/posixmodule.c:13549 and Modules/clinic/posixmodule.c.h:9534 — posix_fallocate was dropped in WASI preview2 due to inconsistent cross-OS semantics.

Python/fileutils.c:3145 — exclude WASI from the fast fcntl(F_GETFD) fd-validity path.
wasi-libc handles fcntl(F_GETFD), but it returns FD_CLOEXEC unconditionally without validating the fd, so it can't detect a bad fd. It's correct to fall back to fstat() for _Py_fd_is_valid.

Modules/_testinternalcapi.c:47, :241 — skip <dlfcn.h>/dladdr address classification.
wasi-libc has dlopen/dlsym stubs (PR #443) and shared-library build support (PR #429), but dladdr is still absent and there's no full runtime dynamic linking.

Modules/errnomodule.c:295 — alias ESHUTDOWN to EPIPE; missing from WASI SDK 16.
Looks like it's still needed. A WASI build uses __errno_values.h (EPIPE 64, no ESHUTDOWN), not musl's generic bits/errno.h. WASI preview1 has no such errno.

Special cases for WASM Stack size

I'm not super clear on the reasons for the smaller stack size limits. I suspect it's related to the 16MiB stack size specified here:

cpython/configure.ac

Line 2500 in 41b3f0a

AS_VAR_APPEND([LDFLAGS_NODIST], [" -z stack-size=16777216 -Wl,--stack-first -Wl,--initial-memory=41943040"])
(side note --stack-first is apparently the default now, so perhaps in future that can be removed).

I suspect these ones need to stay.

  • Parser/parser.c:11 — lower MAXSTACK
  • Tools/peg_generator/pegen/c_generator.py:42 — the template that generates the parser.c cap above.
  • Python/marshal.c:47 — reduced MAX_MARSHAL_STACK_DEPTH

Threading stuff

I didn't go as deep on the threading cases, but as far as I can tell all of these need to stay. There's still no pause() and pthread_exit or pthread_cleanup_push etc. Though there is a discussion on adding pthread_exit to WASI.

  • Include/pyport.h:478 — leave Py_CAN_START_THREADS undefined; non-threaded WASI has no threads.
  • Include/cpython/pthread_stubs.h:21 — coax pthread_* type declarations out of bits/alltypes.h via __NEED_* macros when threads are stubbed.
  • Python/thread_pthread.h:421 — abort() instead of pthread_exit, which wasi-threads lacks. Tracked upstream by wasi-threads#7 ("Is wasi_thread_exit needed?"), still open (created Oct 2022)
  • Python/thread_pthread.h:436 — sleep(9999999) instead of pause(), which wasi-libc lacks.
  • Modules/_testcapimodule.c:2448, :2463, :2469 — no pthread_cleanup_push/pop

Unavailable features

Also didn't look closely at these ones, but I suspect they need to stay - I don't see the semantics of the cpu time clocks changing in WASI any time soon, also I'm not clear on what it would take to implement subinterpreters.

  • Modules/timemodule.c:80, :1272, :1411, :2146 — don't use times() on WASI; no meaningful process CPU accounting (On WASI, time.process_time is not in seconds #115714).
  • Modules/timemodule.c:1347 — disable process-CPU-time via CLOCK_PROCESS_CPUTIME_ID.
  • Modules/timemodule.c:1549 — disable thread-CPU-time via CLOCK_THREAD_CPUTIME_ID.
  • Python/sysmodule.c:3765 — report supports_isolated_interpreters = False; PEP-734 subinterpreters aren't enabled on WASM builds yet.

Vendored third-party code

Changes to these should be considered upstream.

  • Objects/mimalloc/** and Include/internal/mimalloc/** — mimalloc's own WASI port.
  • Modules/expat/xmlparse.c — vendored Expat's own WASI handling.

Activity

  1. aisk
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)
    extension-modulesC modules in the Modules dirC modules in the Modules dir
    OS-wasi
    type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)
    on Aug 31, 2026
  2. brettcannon commented on Aug 31, 2026

    @brettcannon
    brettcannon
    on Aug 31, 2026
    Member
    More actions

    Thanks for looking at all of this!

    I'm not super clear on the reasons for the smaller stack size limits.

    Does the commit history give any clues? There was a lot of playing around with stack sizes last year when trying to make the stack size check not break under WASI (which it still does; we gave up).

    I didn't go as deep on the threading cases, but as far as I can tell all of these need to stay.

    Threading is a whole separate thing that requires support from WASI SDK, so just assume there's no threading support still.

  3. katharosada commented on Oct 13, 2026

    @katharosada
    katharosada
    on Oct 13, 2026
    ContributorAuthor
    More actions

    Cool thanks! Would you like me to send PRs for the small potential cleanups that were identified?

  4. kevinprimeraquecreo-stack
    added this to Project_VKon Oct 18, 2026
  5. github-project-automation
    moved this to Todo in Project_VKon Oct 18, 2026
  6. kevinprimeraquecreo-stack
    added this to Project_VKon Oct 18, 2026
  7. brettcannon commented on Oct 27, 2026

    @brettcannon
    brettcannon
    on Oct 27, 2026
    Member
    More actions

    @katharosada that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-wasiextension-modulesC modules in the Modules dirC modules in the Modules dirinterpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.