Description

pganssle

opened on May 18, 2019

Issue body actions

BPO	36953
Nosy	@rhettinger, @ned-deily, @serhiy-storchaka, @Carreau, @yan12125, @pganssle, @eamanu, @miss-islington, @tirkarthi
PRs	bpo-36953: Delay removal of ABCs from collections. #13409 [3.7] bpo-36953: Delay removal of ABCs from collections. (GH-13409) #16675

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-10-07.13:21:47.846>
created_at = <Date 2019-05-18.00:52:44.426>
labels = ['3.8', 'library', '3.9']
title = 'Remove collections ABCs?'
updated_at = <Date 2019-10-15.07:30:24.791>
user = 'https://github.com/pganssle'

bugs.python.org fields:

activity = <Date 2019-10-15.07:30:24.791>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2019-10-07.13:21:47.846>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2019-05-18.00:52:44.426>
creator = 'p-ganssle'
dependencies = []
files = []
hgrepos = []
issue_num = 36953
keywords = ['patch']
message_count = 9.0
messages = ['342779', '342785', '342806', '344005', '354093', '354094', '354137', '354259', '354693']
nosy_count = 10.0
nosy_names = ['rhettinger', 'ned.deily', 'stutzbach', 'serhiy.storchaka', 'mbussonn', 'yan12125', 'p-ganssle', 'eamanu', 'miss-islington', 'xtreak']
pr_nums = ['13409', '16675']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36953'
versions = ['Python 3.8', 'Python 3.9']

Activity

1. pganssle commented on May 18, 2019

   

   pganssle

   on May 18, 2019

   MemberAuthor

   More actions

   In PR 5640 (#5460), a warning was added that importing ABCs from collections directly is deprecated and will be removed in Python 3.8, but they have not yet been removed and the warning is still active.

   If they are going to be removed, presumably it needs to be done before the feature freeze at the end of May, otherwise, in the meantime, I think the warning needs to be updated to say that it will be removed in Python 3.9.
2. pganssle

   added

   3.8 (EOL)end of lifeend of life

   3.9 (EOL)end of lifeend of life

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on May 18, 2019
3. tirkarthi commented on May 18, 2019

   

   tirkarthi

   on May 18, 2019

   Member

   More actions

   Relevant PR and discussion : #10596 . pip is incompatible due to the vendored copy of html5lib that needs a new release .
4. Carreau commented on May 18, 2019

   

   Carreaumannequin

   on May 18, 2019

   Mannequin

   More actions

   Should it still raise an informative error message with ImportError:

   ImportError: cannot import name 'XXX' from 'collections', please import it from 'collections.abc'.

   or just the "cannot import name 'XXXX'" without the "please import it from 'collections.abc'." ?
5. miss-islington commented on May 30, 2019

   

   miss-islington

   on May 30, 2019

   Contributor

   More actions

   New changeset eea47e0 by Miss Islington (bot) (Matthias Bussonnier) in branch 'master':
   bpo-36953: Delay removal of ABCs from collections. (GH-13409)
   eea47e0
6. tirkarthi commented on Oct 7, 2019

   

   tirkarthi

   on Oct 7, 2019

   Member

   More actions

   The removal was done in https://bugs.python.org/issue25988 . Given that the version in warning message was updated I guess this can be closed.
7. serhiy-storchaka

   closed this as completedon Oct 7, 2019
8. yan12125 commented on Oct 7, 2019

   

   yan12125mannequin

   on Oct 7, 2019

   Mannequin

   More actions

   Lib/collections/init.py on branch 3.7 still states:

   Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

   I think it should also be updated (hopefully before 3.7.5?) as the actual removal turns out to be in 3.9.
9. eamanu commented on Oct 7, 2019

   

   eamanumannequin

   on Oct 7, 2019

   Mannequin

   More actions

   Now was remove from 3.7

   ef092fe

   This issue should be closed, isn't?
10. miss-islington commented on Oct 9, 2019

    

    miss-islington

    on Oct 9, 2019

    Contributor

    More actions

    New changeset 056fa7f by Miss Islington (bot) in branch '3.7':
    bpo-36953: Delay removal of ABCs from collections. (GH-13409)
    056fa7f
11. ned-deily commented on Oct 15, 2019

    

    ned-deily

    on Oct 15, 2019

    Member

    More actions

    New changeset 42b16b2 by Ned Deily (Miss Islington (bot)) in branch '3.7':
    bpo-36953: Delay removal of ABCs from collections. (GH-13409)
    42b16b2
12. ezio-melotti

    transferred this issue fromon Apr 10, 2022

Issue actions