GeezerVison is showing github.com — hmac.new() default parameter change not mentioned in changelog · Issue #83728 · python/cpython

hmac.new() default parameter change not mentioned in changelog #83728

New issue

Copy link

New issue

Copy link

Closed

hmac.new() default parameter change not mentioned in changelog#83728

Copy link

Labels

3.8 (EOL)end of lifeend of lifedocsDocumentation in the Doc dirDocumentation in the Doc dir

Description

wbond

mannequin

opened

on Feb 3, 2020

Issue body actions

BPO	39547
Nosy	@wbond

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-02-03.22:59:34.267>
labels = ['3.8', 'docs']
title = 'hmac.new() default parameter change not mentioned in changelog'
updated_at = <Date 2020-02-03.22:59:34.267>
user = 'https://github.com/wbond'

bugs.python.org fields:

activity = <Date 2020-02-03.22:59:34.267>
actor = 'wbond'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation']
creation = <Date 2020-02-03.22:59:34.267>
creator = 'wbond'
dependencies = []
files = []
hgrepos = []
issue_num = 39547
keywords = []
message_count = 1.0
messages = ['361329']
nosy_count = 2.0
nosy_names = ['docs@python', 'wbond']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue39547'
versions = ['Python 3.8']

Activity

wbond commented on Feb 3, 2020
wbondmannequin
on Feb 3, 2020
MannequinAuthor
More actions
When running code on Python 3.8 that previous was running 3.3, I ran into the issue that the default value for the digestmod parameter of hmac.new() has been changed to backwards-incompatible value.

I generally would have expected such a break to show up in https://docs.python.org/3/whatsnew/3.8.html#api-and-feature-removals. If not there, somewhere on the 3.8 changelog page.
wbond
added
3.8 (EOL)end of lifeend of life
on Feb 3, 2020
wbond
assigned
docspython
on Feb 3, 2020
wbond
added
docsDocumentation in the Doc dirDocumentation in the Doc dir

3.8 (EOL)end of lifeend of life
on Feb 3, 2020
wbond
assigned
docspython
on Feb 3, 2020
wbond
added
docsDocumentation in the Doc dirDocumentation in the Doc dir
on Feb 3, 2020
ezio-melotti
transferred this issue from on Apr 10, 2022
slateny commented on Apr 25, 2022
slateny
on Apr 25, 2022
Contributor
More actions
The removal does seem mentioned under the function section, but I wonder if it should be also noted in the changelog
tiran commented on Apr 25, 2022
tiran
on Apr 25, 2022
Member
More actions
It's documented in the 3.4 changelog, https://docs.python.org/3/whatsnew/3.4.html#hmac
tiran commented on Apr 25, 2022
tiran
on Apr 25, 2022
Member
More actions
I would not object to add a note to the "porting to 3.8" section.
ambv
added a commit that references this issue on Jun 6, 2022
gh-83728: Add hmac.new default parameter deprecation (GH-91939)
56b5daf
miss-islington
added 3 commits that reference this issue on Jun 6, 2022
pythongh-83728: Add hmac.new default parameter deprecation (pythonGH-…
2802784
pythongh-83728: Add hmac.new default parameter deprecation (pythonGH-…
a6609cb
pythongh-83728: Add hmac.new default parameter deprecation (pythonGH-…
b0f97f1
ambv
added 4 commits that reference this issue on Jun 6, 2022
gh-83728: Add hmac.new default parameter deprecation (GH-91939) (GH-9…
f46e30f
gh-83728: Add hmac.new default parameter deprecation (GH-91939) (GH-9…
8dc8b27
gh-83728: Add hmac.new default parameter deprecation (GH-91939) (GH-9…
5776f72
gh-83728: Add hmac.new default parameter deprecation (GH-91939) (GH-9…
e8f2fe3
ambv commented on Jun 6, 2022
ambv
on Jun 6, 2022
Contributor
More actions
Fixed in 3.8+.
ambv
closed this as completed on Jun 6, 2022
serhiy-storchaka
added a commit that references this issue on Jun 26, 2022
Revert 30935 defer bpo45162 to 312 (#94285)
1ffde3e