Description

brettcannon

opened on Feb 27, 2020

Issue body actions

BPO	39777
Nosy	@brettcannon, @zooba, @ammaraskar

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-02-27.21:09:04.987>
labels = []
title = 'Use the codecov GH Action'
updated_at = <Date 2020-02-27.21:26:43.895>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2020-02-27.21:26:43.895>
actor = 'ammar2'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2020-02-27.21:09:04.987>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 39777
keywords = []
message_count = 3.0
messages = ['362839', '362843', '362845']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'steve.dower', 'ammar2']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue39777'
versions = []

Activity

1. brettcannon commented on Feb 27, 2020

   

   brettcannon

   on Feb 27, 2020

   MemberAuthor

   More actions

   Codecov provides a GH Action for uploading coverage reports which we might as well use instead of their bash uploader: https://github.com/marketplace/actions/codecov.
2. ammaraskar commented on Feb 27, 2020

   

   ammaraskar

   on Feb 27, 2020

   Member

   More actions

   This has the disadvantage that it won't work for PRs because Github doesn't make secrets like ${{ secrets.CODECOV_TOKEN }} available in PRs.

   See: codecov/codecov-action#29
3. ammaraskar commented on Feb 27, 2020

   

   ammaraskar

   on Feb 27, 2020

   Member

   More actions

   On a second look, we currently do this anyway:

   cpython/.github/workflows/coverage.yml

   Lines 66 to 70 in 374d998

   	run: |
   	source ./.venv/bin/activate
   	bash <(curl -s https://codecov.io/bash)
   	env:
   	CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

   and don't run coverage for PRs so it shouldn't matter.
4. ezio-melotti

   transferred this issue fromon Apr 10, 2022
5. iritkatriel

   added

   testsTests in the Lib/test dirTests in the Lib/test dir

   on Nov 27, 2023
6. hugovk commented on Feb 24, 2024

   

   hugovk

   on Feb 24, 2024

   Member

   More actions

   No longer relevant, we removed coverage from the CI in #25679.
7. hugovk

   closed this as not plannedon Feb 24, 2024

Issue actions